This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5103

beautifygraph: don't substitute anything for 'X' in rendered graphs
ClosedPublic

Authored by hooper on Oct 14 2018, 8:22 AM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Commits
rHGc2a0bc6412db: beautifygraph: don't substitute anything for 'X' in rendered graphs
Summary

It looks like we never actually render graphs this way, although there's an
example in a comment next to the code that prevents it from being needed (see
graphmod.ascii()).

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

hooper created this revision.Oct 14 2018, 8:22 AM
martinvonz accepted this revision.Oct 31 2018, 1:37 PM
This revision is now accepted and ready to land.Oct 31 2018, 1:37 PM
Closed by commit rHGc2a0bc6412db: beautifygraph: don't substitute anything for 'X' in rendered graphs (authored by hooper). · Explain WhyOct 31 2018, 2:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/beautifygraph.py (2 lines)

Diff 12131

hgext/beautifygraph.py

# extensions which SHIP WITH MERCURIAL. Non-mainline extensions should # extensions which SHIP WITH MERCURIAL. Non-mainline extensions should
# be specifying the version(s) of Mercurial they are tested with, or # be specifying the version(s) of Mercurial they are tested with, or
# leave the attribute unspecified. # leave the attribute unspecified.
testedwith = 'ships-with-hg-core' testedwith = 'ships-with-hg-core'
def prettyedge(before, edge, after): def prettyedge(before, edge, after):
if edge == '~': if edge == '~':
return '\xE2\x95\xA7' # U+2567 ╧ return '\xE2\x95\xA7' # U+2567 ╧
if edge == 'X':
return '\xE2\x95\xB3' # U+2573 ╳
if edge == '/': if edge == '/':
return '\xE2\x95\xB1' # U+2571 ╱ return '\xE2\x95\xB1' # U+2571 ╱
if edge == '-': if edge == '-':
return '\xE2\x94\x80' # U+2500 ─ return '\xE2\x94\x80' # U+2500 ─
if edge == '|': if edge == '|':
return '\xE2\x94\x82' # U+2502 │ return '\xE2\x94\x82' # U+2502 │
if edge == ':': if edge == ':':
return '\xE2\x94\x86' # U+2506 ┆ return '\xE2\x94\x86' # U+2506 ┆