This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5115

testing: remove expectation of error on bad node insert
ClosedPublic

Authored by indygreg on Oct 16 2018, 11:54 AM.

Download Raw Diff

Details

Reviewers

None

Group Reviewers

hg-reviewers

Commits

rHGddeb510d6815: testing: remove expectation of error on bad node insert

Summary

addgroup() doesn't necessarily validate the hashes of each incoming revision.
This is an optimization that allows delta group application to complete faster.

The fact that revlog raises in this particular test is an implementation detail
due to the way revlogs are testing multiple deltas.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 16 2018, 11:54 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptOct 16 2018, 11:54 AM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

indygreg added a child revision: D5116: testing: switch to inserting deltas.Oct 16 2018, 11:54 AM

Closed by commit rHGddeb510d6815: testing: remove expectation of error on bad node insert (authored by indygreg). · Explain WhyOct 16 2018, 1:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/testing/storage.py (7 lines)

Status	Author	Revision
Closed	indygreg	D5136 exchange: support declaring pull depth
Closed	indygreg	D5135 exchangev2: support for calling rawstorefiledata to retrieve raw files
Closed	indygreg	D5134 wireprotov2: implement command for retrieving raw store files
Closed	indygreg	D5133 wireprotov2: add response type that serializes to indefinite length bytestring
Closed	indygreg	D5132 exchangev2: recognize narrow patterns when pulling
Closed	indygreg	D4928 sqlitestore: file storage backend using SQLite
Closed	indygreg	D5118 storageutil: extract most of peek_censored from revlog
Closed	indygreg	D5117 storageutil: convert fileid to bytes to avoid cast to %s
Closed	indygreg	D5116 testing: switch to inserting deltas
Closed	indygreg	D5115 testing: remove expectation of error on bad node insert
Closed	indygreg	D5114 tests: use byte literals in test-storage.py

Diff 12171

mercurial/testing/storage.py


	self.assertEqual(nodes, [])			self.assertEqual(nodes, [])
	self.assertEqual(callbackargs, [])			self.assertEqual(callbackargs, [])
	self.assertEqual(len(f), 0)			self.assertEqual(len(f), 0)

	fulltext0 = b'foo'			fulltext0 = b'foo'
	delta0 = mdiff.trivialdiffheader(len(fulltext0)) + fulltext0			delta0 = mdiff.trivialdiffheader(len(fulltext0)) + fulltext0

	deltas = [
	(b'\x01' * 20, nullid, nullid, nullid, nullid, delta0, 0),
	]

	with self._maketransactionfn() as tr:			with self._maketransactionfn() as tr:
	with self.assertRaises(error.StorageError):
	f.addgroup(deltas, linkmapper, tr, addrevisioncb=cb)

	node0 = f.add(fulltext0, None, tr, 0, nullid, nullid)			node0 = f.add(fulltext0, None, tr, 0, nullid, nullid)

	f = self._makefilefn()			f = self._makefilefn()

	deltas = [			deltas = [
	(node0, nullid, nullid, nullid, nullid, delta0, 0),			(node0, nullid, nullid, nullid, nullid, delta0, 0),
	]			]

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	12163		Oct 16 2018, 11:54 AM	★	★
Diff 2	12171	rHGddeb510d6815371ca868bf820d390a02a8a6d480	Oct 16 2018, 9:24 AM	★	★