This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5115

testing: remove expectation of error on bad node insert
ClosedPublic

Authored by indygreg on Oct 16 2018, 11:54 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGddeb510d6815: testing: remove expectation of error on bad node insert
Summary

addgroup() doesn't necessarily validate the hashes of each incoming revision.
This is an optimization that allows delta group application to complete faster.

The fact that revlog raises in this particular test is an implementation detail
due to the way revlogs are testing multiple deltas.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Oct 16 2018, 11:54 AM
Closed by commit rHGddeb510d6815: testing: remove expectation of error on bad node insert (authored by indygreg). · Explain WhyOct 16 2018, 1:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/testing/storage.py (7 lines)

Diff 12163

mercurial/testing/storage.py

self.assertEqual(nodes, []) self.assertEqual(nodes, [])
self.assertEqual(callbackargs, []) self.assertEqual(callbackargs, [])
self.assertEqual(len(f), 0) self.assertEqual(len(f), 0)
fulltext0 = b'foo' fulltext0 = b'foo'
delta0 = mdiff.trivialdiffheader(len(fulltext0)) + fulltext0 delta0 = mdiff.trivialdiffheader(len(fulltext0)) + fulltext0
deltas = [
(b'\x01' * 20, nullid, nullid, nullid, nullid, delta0, 0),
]
with self._maketransactionfn() as tr: with self._maketransactionfn() as tr:
with self.assertRaises(error.StorageError):
f.addgroup(deltas, linkmapper, tr, addrevisioncb=cb)
node0 = f.add(fulltext0, None, tr, 0, nullid, nullid) node0 = f.add(fulltext0, None, tr, 0, nullid, nullid)
f = self._makefilefn() f = self._makefilefn()
deltas = [ deltas = [
(node0, nullid, nullid, nullid, nullid, delta0, 0), (node0, nullid, nullid, nullid, nullid, delta0, 0),
] ]