This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5172

statprof: update the name as the i increases (issue6003)
ClosedPublic

Authored by pulkit on Oct 19 2018, 4:35 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG4613f9274fc0: statprof: update the name as the i increases (issue6003)
Summary

2864f8d3fcd6 while working on py3 fix, take out the name building out of the
loop so we were not building the new stack-name for each i, rather we were using
the first one again and again.

The test changes shows the profile is now working.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Oct 19 2018, 4:35 PM
pulkit added inline comments.Oct 19 2018, 4:36 PM
tests/test-profile.t
93

I tried to glob this one by putting * at various places but I failed. Any help/suggestion on how to glob this will be helpful.

yuja added a subscriber: yuja.Oct 20 2018, 3:02 AM

+ time seconds seconds name
+ 92.55 0.02 0.02 sleepext.py:7:sleep

$ cat ../out | statprofran

I tried to glob this one by putting * at various places but I failed. Any help/suggestion on how to glob this will be helpful.

Fixed this as * sleepext.py:*:sleep (glob) and queued, thanks.

Closed by commit rHG4613f9274fc0: statprof: update the name as the i increases (issue6003) (authored by pulkit). · Explain WhyOct 20 2018, 3:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/statprof.py (1 line)
Mtests/test-profile.t (2 lines)

Diff 12289

mercurial/statprof.py

self.children[site] = child self.children[site] = child
if len(stack) > 1: if len(stack) > 1:
i = 1 i = 1
# Skip boiler plate parts of the stack # Skip boiler plate parts of the stack
name = r'%s:%s' % (stack[i].filename(), stack[i].function) name = r'%s:%s' % (stack[i].filename(), stack[i].function)
while i < len(stack) and name in skips: while i < len(stack) and name in skips:
i += 1 i += 1
name = r'%s:%s' % (stack[i].filename(), stack[i].function)
if i < len(stack): if i < len(stack):
child.add(stack[i:], time) child.add(stack[i:], time)
root = HotNode(None) root = HotNode(None)
lasttime = data.samples[0].time lasttime = data.samples[0].time
for sample in data.samples: for sample in data.samples:
root.add(sample.stack[::-1], sample.time - lasttime) root.add(sample.stack[::-1], sample.time - lasttime)
lasttime = sample.time lasttime = sample.time

tests/test-profile.t

$ hg --profile sleep 2>../out $ hg --profile sleep 2>../out
$ cat ../out | statprofran $ cat ../out | statprofran
Various statprof formatters work Various statprof formatters work
$ hg --profile --config profiling.statformat=byline sleep 2>../out $ hg --profile --config profiling.statformat=byline sleep 2>../out
$ head -n 3 ../out $ head -n 3 ../out
% cumulative self % cumulative self
time seconds seconds name
* sleepext.py:*:sleep (glob)
pulkitAuthorUnsubmitted
Not Done

I tried to glob this one by putting * at various places but I failed. Any help/suggestion on how to glob this will be helpful.

pulkit: I tried to glob this one by putting * at various places but I failed. Any help/suggestion on…
$ cat ../out | statprofran $ cat ../out | statprofran
$ hg --profile --config profiling.statformat=bymethod sleep 2>../out $ hg --profile --config profiling.statformat=bymethod sleep 2>../out
$ head -n 1 ../out $ head -n 1 ../out
% cumulative self % cumulative self
$ cat ../out | statprofran $ cat ../out | statprofran
$ hg --profile --config profiling.statformat=hotpath sleep 2>../out $ hg --profile --config profiling.statformat=hotpath sleep 2>../out