This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5179

command: reintroduce support for commands starting with ^ (issue6005)
AbandonedPublic

Authored by lothiraldan on Oct 22 2018, 6:24 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

Changeset fa88170c10bb added a new flag for declaring commands that should be
on the shortlist.

While being a good API change, we should allow extensions author declaring new
commands time to update to this new API.

Reintroduce support for commands starting with ^ to appears in the shortlist
with a devel warning. The support will be dropped in 5.0 release.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

lothiraldan created this revision.Oct 22 2018, 6:24 AM
lothiraldan added a comment.Oct 22 2018, 8:56 AM
In D5179#77391, @yuja wrote:

FYI, I've posted a similar fix a few days ago.
https://www.mercurial-scm.org/pipermail/mercurial-devel/2018-October/124142.html

Oups, so sorry I missed it in my mailbox.

Do we have performance concerns around the deprecation, how often is called loadcmdtable? My gut feeling is telling me it shouldn't matter but I would prefer to be sure.

yuja added a comment.Oct 22 2018, 9:28 AM
Do we have performance concerns around the deprecation, how often is called `loadcmdtable`? My gut feeling is telling me it shouldn't matter but I would prefer to be sure.

I don't think my change would cause measurable slowdown. It's called once
per extension.

lothiraldan abandoned this revision.Oct 22 2018, 9:39 AM
In D5179#77396, @yuja wrote:
Do we have performance concerns around the deprecation, how often is called `loadcmdtable`? My gut feeling is telling me it shouldn't matter but I would prefer to be sure.

I don't think my change would cause measurable slowdown. It's called once
per extension.

Ok then your patch is much better as we have access to the ui object. Abandoning my revision.

Revision Contents
Changeset List

PathPackages
Mmercurial/registrar.py (11 lines)

Diff 12295

mercurial/registrar.py

def _doregister(self, func, name, options=(), synopsis=None, def _doregister(self, func, name, options=(), synopsis=None,
norepo=False, optionalrepo=False, inferrepo=False, norepo=False, optionalrepo=False, inferrepo=False,
intents=None, helpcategory=None, helpbasic=False): intents=None, helpcategory=None, helpbasic=False):
func.norepo = norepo func.norepo = norepo
func.optionalrepo = optionalrepo func.optionalrepo = optionalrepo
func.inferrepo = inferrepo func.inferrepo = inferrepo
func.intents = intents or set() func.intents = intents or set()
func.helpcategory = helpcategory func.helpcategory = helpcategory
if name.startswith("^"):
msg = (
"^ command prefix has been deprecated,"
" use `@command(..., helpbasic=True)` instead"
)
util.nouideprecwarn(msg, 5.0)
name = name[1:]
helpbasic = True
func.helpbasic = helpbasic func.helpbasic = helpbasic
if synopsis: if synopsis:
self._table[name] = func, list(options), synopsis self._table[name] = func, list(options), synopsis
else: else:
self._table[name] = func, list(options) self._table[name] = func, list(options)
return func return func
INTENT_READONLY = b'readonly' INTENT_READONLY = b'readonly'