This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5193

remotefilelog: drop compat code for "getbundle_shallow" wireprotocol command
ClosedPublic

Authored by pulkit on Oct 24 2018, 11:49 AM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG2dd3a0201307: remotefilelog: drop compat code for "getbundle_shallow" wireprotocol command
Summary

Doing some annotate on hgexperimental shows that getbundle_shallow used to exist
in 2013 or before. We don't have any pre-2013 remotefilelog users except Fb
themselves and I doubt they are going to use in-core remotefilelog. So it's safe
to remove this.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Oct 24 2018, 11:49 AM
durin42 accepted this revision.Nov 5 2018, 11:01 AM
This revision is now accepted and ready to land.Nov 5 2018, 11:01 AM
Closed by commit rHG2dd3a0201307: remotefilelog: drop compat code for "getbundle_shallow" wireprotocol command (authored by pulkit). · Explain WhyNov 5 2018, 2:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 12429

hgext/remotefilelog/remotefilelogserver.py

raise error.Abort(_("Cannot clone from a shallow repo " raise error.Abort(_("Cannot clone from a shallow repo "
"to a full repo.")) "to a full repo."))
else: else:
for x in orig(repo, matcher): for x in orig(repo, matcher):
yield x yield x
extensions.wrapfunction(streamclone, '_walkstreamfiles', _walkstreamfiles) extensions.wrapfunction(streamclone, '_walkstreamfiles', _walkstreamfiles)
# We no longer use getbundle_shallow commands, but we must still
# support it for migration purposes
def getbundleshallow(repo, proto, others):
bundlecaps = others.get('bundlecaps', '')
bundlecaps = set(bundlecaps.split(','))
bundlecaps.add(constants.BUNDLE2_CAPABLITY)
others['bundlecaps'] = ','.join(bundlecaps)
return wireprotov1server.commands["getbundle"][0](repo, proto, others)
wireprotov1server.commands["getbundle_shallow"] = (getbundleshallow, '*')
# expose remotefilelog capabilities # expose remotefilelog capabilities
def _capabilities(orig, repo, proto): def _capabilities(orig, repo, proto):
caps = orig(repo, proto) caps = orig(repo, proto)
if (shallowutil.isenabled(repo) or ui.configbool('remotefilelog', if (shallowutil.isenabled(repo) or ui.configbool('remotefilelog',
'server')): 'server')):
if isinstance(proto, _sshv1server): if isinstance(proto, _sshv1server):
# legacy getfiles method which only works over ssh # legacy getfiles method which only works over ssh
caps.append(constants.NETWORK_CAP_LEGACY_SSH_GETFILES) caps.append(constants.NETWORK_CAP_LEGACY_SSH_GETFILES)