This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5207

tests: skip wireproto clientreactor tests on Python 3.6.0-3.6.3 inclusive
ClosedPublic

Authored by durin42 on Nov 1 2018, 5:17 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG07b87ee2ea75: tests: skip wireproto clientreactor tests on Python 3.6.0-3.6.3 inclusive
Summary

See comment next to the if statement for sad details.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Nov 1 2018, 5:17 PM
yuja added a subscriber: yuja.Nov 2 2018, 9:32 PM

if name == 'main':
+ if (3, 6, 0) <= sys.version_info <= (3, 6, 3):
+ # Python 3.6.0 through 3.6.3 inclusive shipped with
+ # https://bugs.python.org/issue31825 and we can't run these
+ # tests on those specific versions of Python. Sigh.
+ sys.exit(0)

Changed 0 to 80 to flag the test as skipped.

Closed by commit rHG07b87ee2ea75: tests: skip wireproto clientreactor tests on Python 3.6.0-3.6.3 inclusive (authored by durin42). · Explain WhyNov 2 2018, 9:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 12384

tests/test-wireproto-clientreactor.py

from __future__ import absolute_import from __future__ import absolute_import
import sys
import unittest import unittest
import zlib import zlib
from mercurial import ( from mercurial import (
error, error,
ui as uimod, ui as uimod,
wireprotoframing as framing, wireprotoframing as framing,
) )
action, meta = sendframe(reactor, action, meta = sendframe(reactor,
ffs(b'%d 2 encoded command-response eos %s' % ( ffs(b'%d 2 encoded command-response eos %s' % (
request2.requestid, outstream.flush()))) request2.requestid, outstream.flush())))
self.assertEqual(action, b'responsedata') self.assertEqual(action, b'responsedata')
self.assertEqual(meta[b'data'], response2) self.assertEqual(meta[b'data'], response2)
if __name__ == '__main__': if __name__ == '__main__':
if (3, 6, 0) <= sys.version_info <= (3, 6, 3):
# Python 3.6.0 through 3.6.3 inclusive shipped with
# https://bugs.python.org/issue31825 and we can't run these
# tests on those specific versions of Python. Sigh.
sys.exit(80)
import silenttestrunner import silenttestrunner
silenttestrunner.main(__name__) silenttestrunner.main(__name__)