This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5348

narrowcommands: remove an unrequired `repo.narrowpats` call
ClosedPublic

Authored by pulkit on Nov 30 2018, 9:43 AM.

Details

Reviewers
durin42
martinvonz
Group Reviewers
hg-reviewers
Commits
rHG773572e5cba2: narrowcommands: remove an unrequired `repo.narrowpats` call
Summary

We call that few lines above and do nothing significant in between which can
change the narrowpats. So let's use values returned by that call.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Nov 30 2018, 9:43 AM
martinvonz accepted this revision.Nov 30 2018, 7:31 PM
This revision is now accepted and ready to land.Nov 30 2018, 7:31 PM
Closed by commit rHG773572e5cba2: narrowcommands: remove an unrequired `repo.narrowpats` call (authored by pulkit). · Explain WhyNov 30 2018, 7:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/narrow/narrowcommands.py (6 lines)

Diff 12664

hgext/narrow/narrowcommands.py

addedexcludes -= oldexcludes addedexcludes -= oldexcludes
removedexcludes &= oldexcludes removedexcludes &= oldexcludes
widening = addedincludes or removedexcludes widening = addedincludes or removedexcludes
narrowing = removedincludes or addedexcludes narrowing = removedincludes or addedexcludes
# Only print the current narrowspec. # Only print the current narrowspec.
if only_show: if only_show:
include, exclude = repo.narrowpats
ui.pager('tracked') ui.pager('tracked')
fm = ui.formatter('narrow', opts) fm = ui.formatter('narrow', opts)
for i in sorted(include): for i in sorted(oldincludes):
fm.startitem() fm.startitem()
fm.write('status', '%s ', 'I', label='narrow.included') fm.write('status', '%s ', 'I', label='narrow.included')
fm.write('pat', '%s\n', i, label='narrow.included') fm.write('pat', '%s\n', i, label='narrow.included')
for i in sorted(exclude): for i in sorted(oldexcludes):
fm.startitem() fm.startitem()
fm.write('status', '%s ', 'X', label='narrow.excluded') fm.write('status', '%s ', 'X', label='narrow.excluded')
fm.write('pat', '%s\n', i, label='narrow.excluded') fm.write('pat', '%s\n', i, label='narrow.excluded')
fm.end() fm.end()
return 0 return 0
if not widening and not narrowing: if not widening and not narrowing:
ui.status(_("nothing to widen or narrow\n")) ui.status(_("nothing to widen or narrow\n"))