This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	martinvonz	D5386 remotefilelog: rely on progress helper for keeping track of position
Closed	martinvonz	D5385 remotefilelog: reduce use of "count" container
Closed	martinvonz	D5384 remotefilelog: replace a "a=[expr]; b=a[0]" by "b=expr; a = [b]"
Closed	martinvonz	D5383 remotefilelog: remove an unnecessary update of "count" container
Closed	martinvonz	D5382 remotefilelog: avoid temporarily using "count" variable as synonym for "total"
Closed	martinvonz	D5381 remotefilelog: use progress helper in fileserverclient
Closed	martinvonz	D5380 remotefilelog: use progress helper in shallowrepo
Closed	martinvonz	D5379 remotefilelog: use progress helper in shallowbundle
Closed	martinvonz	D5378 remotefilelog: use progress helper in repack
Closed	martinvonz	D5377 remotefilelog: use progress helper in remotefilelogserver
Closed	martinvonz	D5376 remotefilelog: use progress helper in basestore
Closed	martinvonz	D5375 remotefilelog: use progress helper when analyzing repos
Closed	martinvonz	D5374 fastannotate: use progress helper
Closed	martinvonz	D5373 debugbuildannotatecache: use progress helper
Closed	martinvonz	D5372 perfrevlogwrite: use progress helper on modern hg

Diff 12734

hgext/fastannotate/commands.py

	paths = list(ctx.walk(m))			paths = list(ctx.walk(m))
	if util.safehasattr(repo, 'prefetchfastannotate'):			if util.safehasattr(repo, 'prefetchfastannotate'):
	# client			# client
	if opts.get('REV'):			if opts.get('REV'):
	raise error.Abort(_('--rev cannot be used for client'))			raise error.Abort(_('--rev cannot be used for client'))
	repo.prefetchfastannotate(paths)			repo.prefetchfastannotate(paths)
	else:			else:
	# server, or full repo			# server, or full repo
				progress = ui.makeprogress(_('building'), total=len(paths))
	for i, path in enumerate(paths):			for i, path in enumerate(paths):
	ui.progress(_('building'), i, total=len(paths))			progress.update(i)
	with facontext.annotatecontext(repo, path) as actx:			with facontext.annotatecontext(repo, path) as actx:
	try:			try:
	if actx.isuptodate(rev):			if actx.isuptodate(rev):
	continue			continue
	actx.annotate(rev, rev)			actx.annotate(rev, rev)
	except (faerror.CannotReuseError, faerror.CorruptedFileError):			except (faerror.CannotReuseError, faerror.CorruptedFileError):
	# the cache is broken (could happen with renaming so the			# the cache is broken (could happen with renaming so the
	# file history gets invalidated). rebuild and try again.			# file history gets invalidated). rebuild and try again.
	ui.debug('fastannotate: %s: rebuilding broken cache\n'			ui.debug('fastannotate: %s: rebuilding broken cache\n'
	% path)			% path)
	actx.rebuild()			actx.rebuild()
	try:			try:
	actx.annotate(rev, rev)			actx.annotate(rev, rev)
	except Exception as ex:			except Exception as ex:
	# possibly a bug, but should not stop us from building			# possibly a bug, but should not stop us from building
	# cache for other files.			# cache for other files.
	ui.warn(_('fastannotate: %s: failed to '			ui.warn(_('fastannotate: %s: failed to '
	'build cache: %r\n') % (path, ex))			'build cache: %r\n') % (path, ex))
	# clear the progress bar			progress.complete()
	ui.write()

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	12712		Dec 5 2018, 12:39 PM	★	★
Diff 2	12734	rHG901f6ef670ca5e1a9ed07f31aed4e1930982688d	Dec 4 2018, 6:57 PM	★	★

This is an archive of the discontinued Mercurial Phabricator instance.

debugbuildannotatecache: use progress helperClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 12734

hgext/fastannotate/commands.py

debugbuildannotatecache: use progress helper
ClosedPublic

Revision Contents
Changeset List