This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5373

debugbuildannotatecache: use progress helper
ClosedPublic

Authored by martinvonz on Dec 5 2018, 12:39 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG901f6ef670ca: debugbuildannotatecache: use progress helper
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Dec 5 2018, 12:39 PM
Closed by commit rHG901f6ef670ca: debugbuildannotatecache: use progress helper (authored by martinvonz). · Explain WhyDec 6 2018, 6:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/fastannotate/commands.py (6 lines)

Diff 12712

hgext/fastannotate/commands.py

paths = list(ctx.walk(m)) paths = list(ctx.walk(m))
if util.safehasattr(repo, 'prefetchfastannotate'): if util.safehasattr(repo, 'prefetchfastannotate'):
# client # client
if opts.get('REV'): if opts.get('REV'):
raise error.Abort(_('--rev cannot be used for client')) raise error.Abort(_('--rev cannot be used for client'))
repo.prefetchfastannotate(paths) repo.prefetchfastannotate(paths)
else: else:
# server, or full repo # server, or full repo
progress = ui.makeprogress(_('building'), total=len(paths))
for i, path in enumerate(paths): for i, path in enumerate(paths):
ui.progress(_('building'), i, total=len(paths)) progress.update(i)
with facontext.annotatecontext(repo, path) as actx: with facontext.annotatecontext(repo, path) as actx:
try: try:
if actx.isuptodate(rev): if actx.isuptodate(rev):
continue continue
actx.annotate(rev, rev) actx.annotate(rev, rev)
except (faerror.CannotReuseError, faerror.CorruptedFileError): except (faerror.CannotReuseError, faerror.CorruptedFileError):
# the cache is broken (could happen with renaming so the # the cache is broken (could happen with renaming so the
# file history gets invalidated). rebuild and try again. # file history gets invalidated). rebuild and try again.
ui.debug('fastannotate: %s: rebuilding broken cache\n' ui.debug('fastannotate: %s: rebuilding broken cache\n'
% path) % path)
actx.rebuild() actx.rebuild()
try: try:
actx.annotate(rev, rev) actx.annotate(rev, rev)
except Exception as ex: except Exception as ex:
# possibly a bug, but should not stop us from building # possibly a bug, but should not stop us from building
# cache for other files. # cache for other files.
ui.warn(_('fastannotate: %s: failed to ' ui.warn(_('fastannotate: %s: failed to '
'build cache: %r\n') % (path, ex)) 'build cache: %r\n') % (path, ex))
# clear the progress bar progress.complete()
ui.write()