This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5502

tests: correct version check in clientreactor test
ClosedPublic

Authored by durin42 on Jan 6 2019, 3:28 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG685cf59a134f: tests: correct version check in clientreactor test
Summary

Experimentally, (3, 6, 3) is less than sys.version_info on an actual
Python 3.6.3 installation. Let's just check < (3, 6, 4) instead of
<= (3, 6, 3) so we stop seeing this bogus failure.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jan 6 2019, 3:28 PM
pulkit accepted this revision.Jan 7 2019, 5:32 AM
Closed by commit rHG685cf59a134f: tests: correct version check in clientreactor test (authored by durin42). · Explain WhyJan 7 2019, 5:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 13043

tests/test-wireproto-clientreactor.py

action, meta = sendframe(reactor, action, meta = sendframe(reactor,
ffs(b'%d 2 encoded command-response eos %s' % ( ffs(b'%d 2 encoded command-response eos %s' % (
request2.requestid, outstream.flush()))) request2.requestid, outstream.flush())))
self.assertEqual(action, b'responsedata') self.assertEqual(action, b'responsedata')
self.assertEqual(meta[b'data'], response2) self.assertEqual(meta[b'data'], response2)
if __name__ == '__main__': if __name__ == '__main__':
if (3, 6, 0) <= sys.version_info <= (3, 6, 3): if (3, 6, 0) <= sys.version_info < (3, 6, 4):
# Python 3.6.0 through 3.6.3 inclusive shipped with # Python 3.6.0 through 3.6.3 inclusive shipped with
# https://bugs.python.org/issue31825 and we can't run these # https://bugs.python.org/issue31825 and we can't run these
# tests on those specific versions of Python. Sigh. # tests on those specific versions of Python. Sigh.
sys.exit(80) sys.exit(80)
import silenttestrunner import silenttestrunner
silenttestrunner.main(__name__) silenttestrunner.main(__name__)