This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5530

progress: check what type of progress bar to use only once per topic
ClosedPublic

Authored by martinvonz on Jan 8 2019, 1:10 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG963462786f6e: progress: check what type of progress bar to use only once per topic
Summary

This seems to have sped up hg perfprogress from 1.78 s to 1.41 s.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jan 8 2019, 1:10 PM
Closed by commit rHG963462786f6e: progress: check what type of progress bar to use only once per topic (authored by martinvonz). · Explain WhyJan 9 2019, 2:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 13098

mercurial/scmutil.py

class progress(object): class progress(object):
def __init__(self, ui, topic, unit="", total=None): def __init__(self, ui, topic, unit="", total=None):
self.ui = ui self.ui = ui
self.pos = 0 self.pos = 0
self.topic = topic self.topic = topic
self.unit = unit self.unit = unit
self.total = total self.total = total
self.debug = ui.configbool('progress', 'debug') self.debug = ui.configbool('progress', 'debug')
if getattr(ui._fmsgerr, 'structured', False):
# channel for machine-readable output with metadata, just send
# raw information
# TODO: consider porting some useful information (e.g. estimated
# time) from progbar. we might want to support update delay to
# reduce the cost of transferring progress messages.
def updatebar(item):
ui._fmsgerr.write(None, type=b'progress', topic=self.topic,
pos=self.pos, item=item, unit=self.unit,
total=self.total)
elif ui._progbar is not None:
def updatebar(item):
ui._progbar.progress(self.topic, self.pos, item=item,
unit=self.unit, total=self.total)
else:
def updatebar(item):
pass
self._updatebar = updatebar
def __enter__(self): def __enter__(self):
return self return self
def __exit__(self, exc_type, exc_value, exc_tb): def __exit__(self, exc_type, exc_value, exc_tb):
self.complete() self.complete()
def update(self, pos, item="", total=None): def update(self, pos, item="", total=None):
self.update(self.pos + step, item, total) self.update(self.pos + step, item, total)
def complete(self): def complete(self):
self.pos = None self.pos = None
self.unit = "" self.unit = ""
self.total = None self.total = None
self._updatebar("") self._updatebar("")
def _updatebar(self, item):
if getattr(self.ui._fmsgerr, 'structured', False):
# channel for machine-readable output with metadata, just send
# raw information
# TODO: consider porting some useful information (e.g. estimated
# time) from progbar. we might want to support update delay to
# reduce the cost of transferring progress messages.
self.ui._fmsgerr.write(None, type=b'progress', topic=self.topic,
pos=self.pos, item=item, unit=self.unit,
total=self.total)
elif self.ui._progbar is not None:
self.ui._progbar.progress(self.topic, self.pos, item=item,
unit=self.unit, total=self.total)
def _printdebug(self, item): def _printdebug(self, item):
if self.unit: if self.unit:
unit = ' ' + self.unit unit = ' ' + self.unit
if item: if item:
item = ' ' + item item = ' ' + item
if self.total: if self.total:
pct = 100.0 * self.pos / self.total pct = 100.0 * self.pos / self.total