This is an archive of the discontinued Mercurial Phabricator instance.

progress: deprecate ui.progress()
ClosedPublic

Authored by martinvonz on Jan 8 2019, 1:10 PM.

Details

Summary

It is now just a weird wrapper for ui.makeprogress().

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jan 8 2019, 1:10 PM
martinvonz updated this revision to Diff 13082.Jan 8 2019, 1:28 PM

The new makeprogress API is more clean but more low-level, could we extend the deprecation warning until the 5.1 release to gives more time to extension authors to update?

martinvonz updated this revision to Diff 13095.Jan 9 2019, 11:15 AM

The new makeprogress API is more clean but more low-level, could we extend the deprecation warning until the 5.1 release to gives more time to extension authors to update?

I'm not sure I agree with the first part, but I don't mind extending the deprecation until 5.1. Done.

pulkit accepted this revision.Jan 16 2019, 2:02 AM

Btw, I've sent a patch for evolve: https://bitbucket.org/octobus/evolve-devel/commits/3e07c1eea61d2fe6bc80d75d0062d34e53b40577. Other extension authors should be able to copy that.

Btw, I've sent a patch for evolve: https://bitbucket.org/octobus/evolve-devel/commits/3e07c1eea61d2fe6bc80d75d0062d34e53b40577. Other extension authors should be able to copy that.

Macro goodjob:

This revision was automatically updated to reflect the committed changes.