This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5535

tests: support passing testcase after .t paths that have path separators
ClosedPublic

Authored by spectral on Jan 8 2019, 9:49 PM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Commits
rHG8ddc5d8bea25: tests: support passing testcase after .t paths that have path separators
Summary

This probably could have been implemented by changing the regex above this bit
of code, but I wasn't sure if it would end up handling various OSes correctly,
so I decided to go with this version instead.

Previously:

$ tests/run-tests.py tests/test-ssh.t -l
running 2 tests using 2 parallel processes
..
# Ran 2 tests, 0 skipped, 0 failed.

$ tests/run-tests.py tests/test-ssh.t#sshv1 -l
running 0 tests using 0 parallel processes

# Ran 0 tests, 0 skipped, 0 failed.

Now:

$ tests/run-tests.py tests/test-ssh.t -l
running 2 tests using 2 parallel processes
..
# Ran 2 tests, 0 skipped, 0 failed.

$ tests/run-tests.py tests/test-ssh.t#sshv1 -l
running 1 tests using 1 parallel processes
.
# Ran 1 tests, 0 skipped, 0 failed.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Jan 8 2019, 9:49 PM
martinvonz accepted this revision.Jan 9 2019, 1:01 AM
martinvonz added a subscriber: martinvonz.

Thanks for fixing! I have run into this many times but never spent time trying to understand what the problem was.

This revision is now accepted and ready to land.Jan 9 2019, 1:01 AM
Closed by commit rHG8ddc5d8bea25: tests: support passing testcase after .t paths that have path separators (authored by spectral). · Explain WhyJan 9 2019, 1:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (5 lines)

Diff 13088

tests/run-tests.py

testcasepattern = re.compile(br'([\w-]+\.t|py)(#([a-zA-Z0-9_\-\.#]+))') testcasepattern = re.compile(br'([\w-]+\.t|py)(#([a-zA-Z0-9_\-\.#]+))')
tests = [] tests = []
for t in args: for t in args:
case = [] case = []
if not (os.path.basename(t).startswith(b'test-') if not (os.path.basename(t).startswith(b'test-')
and (t.endswith(b'.py') or t.endswith(b'.t'))): and (t.endswith(b'.py') or t.endswith(b'.t'))):
m = testcasepattern.match(t) m = testcasepattern.match(os.path.basename(t))
if m is not None: if m is not None:
t, _, casestr = m.groups() t_basename, _, casestr = m.groups()
t = os.path.join(os.path.dirname(t), t_basename)
if casestr: if casestr:
case = casestr.split(b'#') case = casestr.split(b'#')
else: else:
continue continue
if t.endswith(b'.t'): if t.endswith(b'.t'):
# .t file may contain multiple test cases # .t file may contain multiple test cases
casedimensions = parsettestcases(t) casedimensions = parsettestcases(t)