Page MenuHomePhabricator

tests: support passing testcase after .t paths that have path separators
ClosedPublic

Authored by spectral on Jan 8 2019, 9:49 PM.

Details

Summary

This probably could have been implemented by changing the regex above this bit
of code, but I wasn't sure if it would end up handling various OSes correctly,
so I decided to go with this version instead.

Previously:

$ tests/run-tests.py tests/test-ssh.t -l
running 2 tests using 2 parallel processes
..
# Ran 2 tests, 0 skipped, 0 failed.

$ tests/run-tests.py tests/test-ssh.t#sshv1 -l
running 0 tests using 0 parallel processes

# Ran 0 tests, 0 skipped, 0 failed.

Now:

$ tests/run-tests.py tests/test-ssh.t -l
running 2 tests using 2 parallel processes
..
# Ran 2 tests, 0 skipped, 0 failed.

$ tests/run-tests.py tests/test-ssh.t#sshv1 -l
running 1 tests using 1 parallel processes
.
# Ran 1 tests, 0 skipped, 0 failed.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Jan 8 2019, 9:49 PM
martinvonz accepted this revision.Jan 9 2019, 1:01 AM
martinvonz added a subscriber: martinvonz.

Thanks for fixing! I have run into this many times but never spent time trying to understand what the problem was.

This revision is now accepted and ready to land.Jan 9 2019, 1:01 AM
This revision was automatically updated to reflect the committed changes.