( )⚙ D5541 histedit: drop unused constructor arguments (API)

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5541

histedit: drop unused constructor arguments (API)
ClosedPublic

Authored by martinvonz on Jan 9 2019, 6:39 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHGa3a24ad10efb: histedit: drop unused constructor arguments (API)
Summary

All in-tree callers pass a repo and nothing else.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Jan 9 2019, 6:39 PM
Closed by commit rHGa3a24ad10efb: histedit: drop unused constructor arguments (API) (authored by martinvonz). · Explain WhyJan 10 2019, 6:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/histedit.py (20 lines)

Diff 13118

hgext/histedit.py

hints.append("Deleting a changeset from the list " hints.append("Deleting a changeset from the list "
"will DISCARD it from the edited history!") "will DISCARD it from the edited history!")
lines = (intro % (first, last)).split('\n') + actions + hints lines = (intro % (first, last)).split('\n') + actions + hints
return ''.join(['# %s\n' % l if l else '#\n' for l in lines]) return ''.join(['# %s\n' % l if l else '#\n' for l in lines])
class histeditstate(object): class histeditstate(object):
def __init__(self, repo, parentctxnode=None, actions=None, keep=None, def __init__(self, repo):
topmost=None, replacements=None, lock=None, wlock=None):
self.repo = repo self.repo = repo
self.actions = actions self.actions = None
self.keep = keep self.keep = None
self.topmost = topmost self.topmost = None
self.parentctxnode = parentctxnode self.parentctxnode = None
self.lock = lock self.lock = None
self.wlock = wlock self.wlock = None
self.backupfile = None self.backupfile = None
self.stateobj = statemod.cmdstate(repo, 'histedit-state') self.stateobj = statemod.cmdstate(repo, 'histedit-state')
if replacements is None:
self.replacements = [] self.replacements = []
else:
self.replacements = replacements
def read(self): def read(self):
"""Load histedit state from disk and set fields appropriately.""" """Load histedit state from disk and set fields appropriately."""
if not self.stateobj.exists(): if not self.stateobj.exists():
cmdutil.wrongtooltocontinue(self.repo, _('histedit')) cmdutil.wrongtooltocontinue(self.repo, _('histedit'))
data = self._read() data = self._read()