This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5590

watchman: ignore some of watchman errors
AbandonedPublic

Authored by lothiraldan on Jan 15 2019, 11:57 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Summary

Don't display 'illegal_fstypes' errors. In environments with network
filesystems, the error messages are quickly pilling up and polluting outputs.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

lothiraldan created this revision.Jan 15 2019, 11:57 AM
lothiraldan added a comment.Jan 15 2019, 12:51 PM

This series is non-urgent and it's fine if not included in the RC. I would like to gather feedback from fsmonitor experts on it but phabricator doesn't allow to set a RFC flag

indygreg accepted this revision.Jan 16 2019, 4:33 PM
indygreg added a subscriber: indygreg.

I don't suppose there's a way to easily test this? I'm guessing not...

The change seems reasonable though.

This revision is now accepted and ready to land.Jan 16 2019, 4:33 PM
lothiraldan added a comment.Jan 17 2019, 11:47 AM
In D5590#82940, @indygreg wrote:

I don't suppose there's a way to easily test this? I'm guessing not...
The change seems reasonable though.

Unfortunately, I don't see an easy way to test it

Thank you for your thorough review of the series, I will wait after the RC to send a new version as it's a non-urgent series

lothiraldan abandoned this revision.Feb 13 2019, 11:23 AM

Resent as D5955

Revision Contents
Changeset List

PathPackages
Mhgext/fsmonitor/__init__.py (3 lines)

Diff 14074

hgext/fsmonitor/__init__.py

# and will disable itself when encountering one of these: # and will disable itself when encountering one of these:
_blacklist = ['largefiles', 'eol'] _blacklist = ['largefiles', 'eol']
def _handleunavailable(ui, state, ex): def _handleunavailable(ui, state, ex):
"""Exception handler for Watchman interaction exceptions""" """Exception handler for Watchman interaction exceptions"""
if isinstance(ex, watchmanclient.Unavailable): if isinstance(ex, watchmanclient.Unavailable):
# experimental config: fsmonitor.verbose # experimental config: fsmonitor.verbose
if ex.warn and ui.configbool('fsmonitor', 'verbose'): if ex.warn and ui.configbool('fsmonitor', 'verbose'):
if 'illegal_fstypes' not in str(ex):
ui.warn(str(ex) + '\n') ui.warn(str(ex) + '\n')
if ex.invalidate: if ex.invalidate:
state.invalidate() state.invalidate()
# experimental config: fsmonitor.verbose # experimental config: fsmonitor.verbose
if ui.configbool('fsmonitor', 'verbose'): if ui.configbool('fsmonitor', 'verbose'):
ui.log('fsmonitor', 'Watchman unavailable: %s\n', ex.msg) ui.log('fsmonitor', 'Watchman unavailable: %s\n', ex.msg)
else: else:
ui.log('fsmonitor', 'Watchman exception: %s\n', ex) ui.log('fsmonitor', 'Watchman exception: %s\n', ex)