Page MenuHomePhabricator

commit: print "commit message saved in" message also if bookmark update fails
ClosedPublic

Authored by martinvonz on Jan 17 2019, 12:28 AM.

Details

Summary

The bookmark update is done within the same transaction, so if fails,
the commit will also be rolled back.

I just happened to notice this while messing with this code; we have
not had reports of crashing bookmark updates from our users.

The same applies to the clearing of the merge state, although I don't
think that's currently tied into the transaction.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped