localrepo: use context manager for transaction in commit()
ClosedPublic

Authored by martinvonz on Jan 17 2019, 12:28 AM.

Details

Summary

A side-effect is that the transaction is released a little earlier, so
the "commit message saved in ..." messages now comes after the
"rollback completed" message. That seems slightly better to me.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
martinvonz created this revision.Jan 17 2019, 12:28 AM

I have the impression that the test changes are due to the previous patch in the stack.

I have the impression that the test changes are due to the previous patch in the stack.

I don't think so. See commit message for why I think they changed.

lothiraldan accepted this revision.Jan 18 2019, 1:59 AM

I have the impression that the test changes are due to the previous patch in the stack.

I don't think so. See commit message for why I think they changed.

Right, I was confused between the time the transaction was closed and the time the transaction was released.

This revision was automatically updated to reflect the committed changes.