This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5640

fuzz: don't allow enormous revlog inputs either
ClosedPublic

Authored by durin42 on Jan 22 2019, 12:01 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGafc33a5705b9: fuzz: don't allow enormous revlog inputs either
Summary

I'm about to make the fuzzer do more, and without this it was getting
enthusiastic about large (and therefore slow) inputs that I don't
think buy us much.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jan 22 2019, 12:01 PM
Closed by commit rHGafc33a5705b9: fuzz: don't allow enormous revlog inputs either (authored by durin42). · Explain WhyJan 23 2019, 12:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/fuzz/revlog.cc (5 lines)

Diff 13353

contrib/fuzz/revlog.cc

# print e # print e
)py", )py",
"fuzzer", Py_file_input); "fuzzer", Py_file_input);
return 0; return 0;
} }
int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size) int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size)
{ {
// Don't allow fuzzer inputs larger than 60k, since we'll just bog
// down and not accomplish much.
if (Size > 60000) {
return 0;
}
PyObject *text = PyObject *text =
PyBytes_FromStringAndSize((const char *)Data, (Py_ssize_t)Size); PyBytes_FromStringAndSize((const char *)Data, (Py_ssize_t)Size);
PyObject *locals = PyDict_New(); PyObject *locals = PyDict_New();
PyDict_SetItemString(locals, "data", text); PyDict_SetItemString(locals, "data", text);
PyObject *res = PyEval_EvalCode(code, contrib::pyglobals(), locals); PyObject *res = PyEval_EvalCode(code, contrib::pyglobals(), locals);
if (!res) { if (!res) {
PyErr_Print(); PyErr_Print();
} }
Py_XDECREF(res); Py_XDECREF(res);
Py_DECREF(locals); Py_DECREF(locals);
Py_DECREF(text); Py_DECREF(text);
return 0; // Non-zero return values are reserved for future use. return 0; // Non-zero return values are reserved for future use.
} }
} }