This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5641

fuzz: exercise more of the revlog API
ClosedPublic

Authored by durin42 on Jan 22 2019, 12:02 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGebe51a2e75be: fuzz: exercise more of the revlog API
Summary

I noticed in the coverage report that we didn't have much coverage in
revlog.py. Let's try and get some of the more interesting bits tested
by the fuzzer. I ran this locally for a few minutes to verify that I
appear to be calling the various functions in reasonable ways.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jan 22 2019, 12:02 PM
martinvonz added a subscriber: martinvonz.Jan 23 2019, 12:39 AM
martinvonz added inline comments.
contrib/fuzz/revlog.cc
22

nit: could have relied on revlog.__iter__ and used just index instead of range(len(index)) here and on the next line

Closed by commit rHGebe51a2e75be: fuzz: exercise more of the revlog API (authored by durin42). · Explain WhyJan 23 2019, 12:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/fuzz/revlog.cc (5 lines)

Diff 13354

contrib/fuzz/revlog.cc

extern "C" int LLVMFuzzerInitialize(int *argc, char ***argv) extern "C" int LLVMFuzzerInitialize(int *argc, char ***argv)
{ {
contrib::initpy(*argv[0]); contrib::initpy(*argv[0]);
code = (PyCodeObject *)Py_CompileString(R"py( code = (PyCodeObject *)Py_CompileString(R"py(
from parsers import parse_index2 from parsers import parse_index2
for inline in (True, False): for inline in (True, False):
try: try:
index, cache = parse_index2(data, inline) index, cache = parse_index2(data, inline)
index.slicechunktodensity(list(range(len(index))), 0.5, 262144)
martinvonzUnsubmitted
Not Done

nit: could have relied on revlog.__iter__ and used just index instead of range(len(index)) here and on the next line

martinvonz: nit: could have relied on `revlog.__iter__` and used just `index` instead of `range(len…
for rev in range(len(index)):
node = index[rev][7]
partial = index.shortest(node)
index.partialmatch(node[:partial])
except Exception as e: except Exception as e:
pass pass
# uncomment this print if you're editing this Python code # uncomment this print if you're editing this Python code
# to debug failures. # to debug failures.
# print e # print e
)py", )py",
"fuzzer", Py_file_input); "fuzzer", Py_file_input);
return 0; return 0;