If the treemanifest is loaded, but not enabled for a repo, it was still
executing tree code for that repo, which would break. This adds checks to
prevent tree code from running in non-tree repositories.
Details
- Reviewers
simonfar - Group Reviewers
Restricted Project - Commits
- rFBHGX0f6b7844affa: treemanifest: fix non-tree repos when treemanifest is loaded
Diff Detail
- Repository
- rFBHGX Facebook Mercurial Extensions
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
treemanifest/__init__.py | ||
---|---|---|
134–136 | When would this return True? Surely if the extension is not loaded, this code never runs? |
treemanifest/__init__.py | ||
---|---|---|
134–136 | I'm not sure I understand the question. This returns True in the vast majority of cases because the extension is loaded and enabled. This returns False when the extension is loaded in python, but not enabled in the current repository. For instance, if I hg pull from one local repo to another local repo, we'll load the extensions for both, but the extensions may only be enabled in one. |
treemanifest/__init__.py | ||
---|---|---|
134–136 | You answered the question I meant to ask (what makes it return False). :) |
When would this return True? Surely if the extension is not loaded, this code never runs?