This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5684

py3: fix test-update-atomic.t
ClosedPublic

Authored by durin42 on Jan 24 2019, 3:03 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG40787a96fda7: py3: fix test-update-atomic.t

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Jan 24 2019, 3:03 PM
pulkit added inline comments.Jan 24 2019, 3:10 PM
tests/test-update-atomic.t
13

hm, why is this change required?

durin42 added inline comments.Jan 24 2019, 3:11 PM
tests/test-update-atomic.t
13
% python -c 'print(oct(10))'
012
% python3 -c 'print(oct(10))'
0o12
pulkit added inline comments.Jan 24 2019, 3:16 PM
tests/test-update-atomic.t
13

Will add the above to commit message in flight.

pulkit accepted this revision.Jan 24 2019, 3:17 PM
Closed by commit rHG40787a96fda7: py3: fix test-update-atomic.t (authored by durin42). · Explain WhyJan 24 2019, 3:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 13423

contrib/python3-whitelist

test-ui-verbosity.py test-ui-verbosity.py
test-unamend.t test-unamend.t
test-unbundlehash.t test-unbundlehash.t
test-uncommit.t test-uncommit.t
test-unified-test.t test-unified-test.t
test-unionrepo.t test-unionrepo.t
test-unrelated-pull.t test-unrelated-pull.t
test-up-local-change.t test-up-local-change.t
test-update-atomic.t
test-update-branches.t test-update-branches.t
test-update-dest.t test-update-dest.t
test-update-issue1456.t test-update-issue1456.t
test-update-names.t test-update-names.t
test-update-reverse.t test-update-reverse.t
test-upgrade-repo.t test-upgrade-repo.t
test-url-download.t test-url-download.t
test-url-rev.t test-url-rev.t

tests/test-update-atomic.t

#require execbit unix-permissions #require execbit unix-permissions
Checking that experimental.atomic-file works. Checking that experimental.atomic-file works.
$ cat > $TESTTMP/show_mode.py <<EOF $ cat > $TESTTMP/show_mode.py <<EOF
> from __future__ import print_function > from __future__ import print_function
> import sys > import sys
> import os > import os
> from stat import ST_MODE > from stat import ST_MODE
> >
> for file_path in sys.argv[1:]: > for file_path in sys.argv[1:]:
> file_stat = os.stat(file_path) > file_stat = os.stat(file_path)
> octal_mode = oct(file_stat[ST_MODE] & 0o777) > octal_mode = oct(file_stat[ST_MODE] & 0o777).replace('o', '')
pulkitUnsubmitted
Not Done

hm, why is this change required?

pulkit: hm, why is this change required?
durin42AuthorUnsubmitted
Not Done
% python -c 'print(oct(10))'
012
% python3 -c 'print(oct(10))'
0o12
durin42: ``` % python -c 'print(oct(10))' 012 % python3 -c 'print(oct(10))' 0o12 ```
pulkitUnsubmitted
Not Done

Will add the above to commit message in flight.

pulkit: Will add the above to commit message in flight.
> print("%s:%s" % (file_path, octal_mode)) > print("%s:%s" % (file_path, octal_mode))
> >
> EOF > EOF
$ hg init repo $ hg init repo
$ cd repo $ cd repo
$ cat > .hg/showwrites.py <<EOF $ cat > .hg/showwrites.py <<EOF
> from __future__ import print_function
> from mercurial import pycompat
> from mercurial.utils import stringutil
> def uisetup(ui): > def uisetup(ui):
> from mercurial import vfs > from mercurial import vfs
> class newvfs(vfs.vfs): > class newvfs(vfs.vfs):
> def __call__(self, *args, **kwargs): > def __call__(self, *args, **kwargs):
> print('vfs open', args, sorted(list(kwargs.items()))) > print(pycompat.sysstr(stringutil.pprint(
> ('vfs open', args, sorted(list(kwargs.items()))))))
> return super(newvfs, self).__call__(*args, **kwargs) > return super(newvfs, self).__call__(*args, **kwargs)
> vfs.vfs = newvfs > vfs.vfs = newvfs
> EOF > EOF
$ for v in a1 a2 b1 b2 c ro; do echo $v > $v; done $ for v in a1 a2 b1 b2 c ro; do echo $v > $v; done
$ chmod +x b* $ chmod +x b*
$ hg commit -Aqm _ $ hg commit -Aqm _