This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5701

tests: add b'' when testing for tls1.2
ClosedPublic

Authored by indygreg on Jan 25 2019, 7:01 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG423a6b2ddafa: tests: add b'' when testing for tls1.2
rHGd33419330c79: tests: add b'' when testing for tls1.2
Summary

The dict keys are bytes. The test was always failing due to
looking for a str key.

skip-blame: just b'' prefix

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Jan 25 2019, 7:01 PM
Closed by commit rHGd33419330c79: tests: add b'' when testing for tls1.2 (authored by indygreg). · Explain WhyJan 25 2019, 9:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/hghave.py (2 lines)

Diff 13479

tests/hghave.py

else: else:
ctx.load_default_certs() ctx.load_default_certs()
return len(ctx.get_ca_certs()) > 0 return len(ctx.get_ca_certs()) > 0
@check("tls1.2", "TLS 1.2 protocol support") @check("tls1.2", "TLS 1.2 protocol support")
def has_tls1_2(): def has_tls1_2():
from mercurial import sslutil from mercurial import sslutil
return 'tls1.2' in sslutil.supportedprotocols return b'tls1.2' in sslutil.supportedprotocols
@check("windows", "Windows") @check("windows", "Windows")
def has_windows(): def has_windows():
return os.name == 'nt' return os.name == 'nt'
@check("system-sh", "system() uses sh") @check("system-sh", "system() uses sh")
def has_system_sh(): def has_system_sh():
return os.name != 'nt' return os.name != 'nt'