This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5703

tests: add b'' prefixes to ui.configbool() call
ClosedPublic

Authored by indygreg on Jan 25 2019, 7:01 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG0cfbe78fc13e: tests: add b'' prefixes to ui.configbool() call
rHG414dbed467f6: tests: add b'' prefixes to ui.configbool() call
Summary

Otherwise the call fails due to using str on Python 3.

  1. skip-blame: just b'' prefixes

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Jan 25 2019, 7:01 PM
Closed by commit rHG414dbed467f6: tests: add b'' prefixes to ui.configbool() call (authored by indygreg). · Explain WhyJan 25 2019, 9:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-http-protocol.t (2 lines)

Diff 13481

tests/test-http-protocol.t

> from mercurial import extensions, wireprotoserver > from mercurial import extensions, wireprotoserver
> def wrappedcallhttp(orig, repo, req, res, proto, cmd): > def wrappedcallhttp(orig, repo, req, res, proto, cmd):
> path = req.advertisedurl[len(req.advertisedbaseurl):] > path = req.advertisedurl[len(req.advertisedbaseurl):]
> if not path.startswith(b'/redirector'): > if not path.startswith(b'/redirector'):
> return orig(repo, req, res, proto, cmd) > return orig(repo, req, res, proto, cmd)
> relpath = path[len(b'/redirector'):] > relpath = path[len(b'/redirector'):]
> res.status = b'301 Redirect' > res.status = b'301 Redirect'
> newurl = b'%s/redirected%s' % (req.baseurl, relpath) > newurl = b'%s/redirected%s' % (req.baseurl, relpath)
> if not repo.ui.configbool('testing', 'redirectqs', True) and b'?' in newurl: > if not repo.ui.configbool(b'testing', b'redirectqs', True) and b'?' in newurl:
> newurl = newurl[0:newurl.index(b'?')] > newurl = newurl[0:newurl.index(b'?')]
> res.headers[b'Location'] = newurl > res.headers[b'Location'] = newurl
> res.headers[b'Content-Type'] = b'text/plain' > res.headers[b'Content-Type'] = b'text/plain'
> res.setbodybytes(b'redirected') > res.setbodybytes(b'redirected')
> return True > return True
> >
> extensions.wrapfunction(wireprotoserver, '_callhttp', wrappedcallhttp) > extensions.wrapfunction(wireprotoserver, '_callhttp', wrappedcallhttp)
> EOF > EOF