| pulkit |
| hg-reviewers |
This code may have been written before Python had a bool type.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| pass | pass | ||||
| def get_ready_conn(self, host): | def get_ready_conn(self, host): | ||||
| conn = None | conn = None | ||||
| self._lock.acquire() | self._lock.acquire() | ||||
| try: | try: | ||||
| for c in self._hostmap[host]: | for c in self._hostmap[host]: | ||||
| if self._readymap[c]: | if self._readymap[c]: | ||||
| self._readymap[c] = 0 | self._readymap[c] = False | ||||
| conn = c | conn = c | ||||
| break | break | ||||
| finally: | finally: | ||||
| self._lock.release() | self._lock.release() | ||||
| return conn | return conn | ||||
| def get_all(self, host=None): | def get_all(self, host=None): | ||||
| if host: | if host: | ||||
| for host, conns in self._cm.get_all().iteritems(): | for host, conns in self._cm.get_all().iteritems(): | ||||
| for h in conns: | for h in conns: | ||||
| self._cm.remove(h) | self._cm.remove(h) | ||||
| h.close() | h.close() | ||||
| def _request_closed(self, request, host, connection): | def _request_closed(self, request, host, connection): | ||||
| """tells us that this request is now closed and that the | """tells us that this request is now closed and that the | ||||
| connection is ready for another request""" | connection is ready for another request""" | ||||
| self._cm.set_ready(connection, 1) | self._cm.set_ready(connection, True) | ||||
| def _remove_connection(self, host, connection, close=0): | def _remove_connection(self, host, connection, close=0): | ||||
| if close: | if close: | ||||
| connection.close() | connection.close() | ||||
| self._cm.remove(connection) | self._cm.remove(connection) | ||||
| #### Transaction Execution | #### Transaction Execution | ||||
| def http_open(self, req): | def http_open(self, req): | ||||
| self._cm.remove(h) | self._cm.remove(h) | ||||
| h = self._cm.get_ready_conn(host) | h = self._cm.get_ready_conn(host) | ||||
| else: | else: | ||||
| # no (working) free connections were found. Create a new one. | # no (working) free connections were found. Create a new one. | ||||
| h = http_class(host, timeout=self._timeout) | h = http_class(host, timeout=self._timeout) | ||||
| if DEBUG: | if DEBUG: | ||||
| DEBUG.info("creating new connection to %s (%d)", | DEBUG.info("creating new connection to %s (%d)", | ||||
| host, id(h)) | host, id(h)) | ||||
| self._cm.add(host, h, 0) | self._cm.add(host, h, False) | ||||
| self._start_transaction(h, req) | self._start_transaction(h, req) | ||||
| r = h.getresponse() | r = h.getresponse() | ||||
| # The string form of BadStatusLine is the status line. Add some context | # The string form of BadStatusLine is the status line. Add some context | ||||
| # to make the error message slightly more useful. | # to make the error message slightly more useful. | ||||
| except httplib.BadStatusLine as err: | except httplib.BadStatusLine as err: | ||||
| raise urlerr.urlerror( | raise urlerr.urlerror( | ||||
| _('bad HTTP status line: %s') % pycompat.sysbytes(err.line)) | _('bad HTTP status line: %s') % pycompat.sysbytes(err.line)) | ||||
| except (socket.error, httplib.HTTPException) as err: | except (socket.error, httplib.HTTPException) as err: | ||||