This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5739

montone: fix addition to list by using .append() instead of '+'
ClosedPublic

Authored by pulkit on Jan 29 2019, 5:27 PM.

Download Raw Diff

Details

Reviewers

None

Group Reviewers

hg-reviewers

Commits

rHG210a999bd668: montone: fix addition to list by using .append() instead of '+'
rHG0a4a3e5c068c: montone: fix addition to list by using .append() instead of '+'
rHGa97e000b63c8: montone: fix addition to list by using .append() instead of '+'

Summary

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Jan 29 2019, 5:27 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptJan 29 2019, 5:27 PM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

pulkit added a child revision: D5740: py3: pass str into RuntimeError() to prevent b'' in output.Jan 29 2019, 5:27 PM

command.append('l')
for arg in args:
command += "%d:%s" % (len(arg), arg)

+ command += pycompat.bytestr("%d:%s" % (len(arg), arg))

It's okay, but I think the original code would mean to do command.append(...).

command.append('e')
command = ''.join(command)

pulkit retitled this revision from py3: use pycompat.bytestr() so that slicing does not result in ascii values to montone: fix addition to list by using .append() instead of '+'.Feb 1 2019, 6:31 PM

pulkit added a child revision: D5794: py3: pass str into grp.getgrnam.

pulkit updated this revision to Diff 13677.

Closed by commit rHGa97e000b63c8: montone: fix addition to list by using .append() instead of '+' (authored by pulkit). · Explain WhyFeb 1 2019, 7:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			hgext/convert/monotone.py (2 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	13561		Jan 29 2019, 5:27 PM	★	★
Diff 2	13677		Feb 1 2019, 6:31 PM	★	★
Diff 3	13682	rHGa97e000b63c84b7b2db54b67870cada413d4320f	Jan 29 2019, 5:20 PM	★	★

Status	Author	Revision
Closed	pulkit	D5740 py3: pass str into RuntimeError() to prevent b'' in output
Closed	pulkit	D5794 py3: pass str into grp.getgrnam
Closed	pulkit	D5739 montone: fix addition to list by using .append() instead of '+'
Closed	pulkit	D5738 py3: use '%d' instead of '%s' for integers
Needs Revision	pulkit	D5737 py3: convert info.name to bytes in subrepo.py

Diff 13682

hgext/convert/monotone.py

	if v:			if v:
	command.append("%d:%s" % (len(v), v))			command.append("%d:%s" % (len(v), v))
	if command:			if command:
	command.insert(0, 'o')			command.insert(0, 'o')
	command.append('e')			command.append('e')

	command.append('l')			command.append('l')
	for arg in args:			for arg in args:
	command += "%d:%s" % (len(arg), arg)			command.append("%d:%s" % (len(arg), arg))
	command.append('e')			command.append('e')
	command = ''.join(command)			command = ''.join(command)

	self.ui.debug("mtn: sending '%s'\n" % command)			self.ui.debug("mtn: sending '%s'\n" % command)
	self.mtnwritefp.write(command)			self.mtnwritefp.write(command)
	self.mtnwritefp.flush()			self.mtnwritefp.flush()

	return self.mtnstdioreadcommandoutput(command)			return self.mtnstdioreadcommandoutput(command)