This is an archive of the discontinued Mercurial Phabricator instance.

Differential D576

run-tests: pass --with-hg to run-tests.py command used by bisect
ClosedPublic

Authored by quark on Aug 30 2017, 6:36 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG72b23c9452d6: run-tests: pass --with-hg to run-tests.py command used by bisect
Summary

This makes run-tests.py -l test-run-tests.t 23 seconds faster on my
laptop. Inside the test, $ rt --known-good-rev=0 test-bisect.t took 24.9
seconds before, and 1.2 seconds after.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Aug 30 2017, 6:36 PM
yuja accepted this revision.Sep 1 2017, 9:15 AM
yuja added a subscriber: yuja.

Queued the series, thanks.

This revision is now accepted and ready to land.Sep 1 2017, 9:15 AM
Closed by commit rHG72b23c9452d6: run-tests: pass --with-hg to run-tests.py command used by bisect (authored by quark). · Explain WhySep 1 2017, 9:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (9 lines)

Diff 1534

tests/run-tests.py

stdout=subprocess.PIPE) stdout=subprocess.PIPE)
p.stdout.read() p.stdout.read()
p.wait() p.wait()
for test, msg in result.failures: for test, msg in result.failures:
nooutput(['hg', 'bisect', '--reset']), nooutput(['hg', 'bisect', '--reset']),
nooutput(['hg', 'bisect', '--bad', '.']) nooutput(['hg', 'bisect', '--bad', '.'])
nooutput(['hg', 'bisect', '--good', nooutput(['hg', 'bisect', '--good',
self._runner.options.known_good_rev]) self._runner.options.known_good_rev])
# TODO: we probably need to forward some options # TODO: we probably need to forward more options
# that alter hg's behavior inside the tests. # that alter hg's behavior inside the tests.
rtc = '%s %s %s' % (sys.executable, sys.argv[0], test) opts = ''
withhg = self._runner.options.with_hg
if withhg:
opts += ' --with-hg=%s ' % shellquote(withhg)
rtc = '%s %s %s %s' % (sys.executable, sys.argv[0], opts,
test)
sub = subprocess.Popen(['hg', 'bisect', '--command', rtc], sub = subprocess.Popen(['hg', 'bisect', '--command', rtc],
stderr=subprocess.STDOUT, stderr=subprocess.STDOUT,
stdout=subprocess.PIPE) stdout=subprocess.PIPE)
data = sub.stdout.read() data = sub.stdout.read()
sub.wait() sub.wait()
m = re.search( m = re.search(
(r'\nThe first (?P<goodbad>bad|good) revision ' (r'\nThe first (?P<goodbad>bad|good) revision '
r'is:\nchangeset: +\d+:(?P<node>[a-f0-9]+)\n.*\n' r'is:\nchangeset: +\d+:(?P<node>[a-f0-9]+)\n.*\n'