Otherwise mid is a float and this confuses slice on Python 3.
Details
Details
Diff Detail
Diff Detail
- Repository
- rHG Mercurial
- Lint
Lint Skipped - Unit
Unit Tests Skipped
This is an archive of the discontinued Mercurial Phabricator instance.
Differential D5760
remotefilelog: cast division result to an intClosedPublic
remotefilelog: cast division result to an int
ClosedPublic
Authored by indygreg on Jan 30 2019, 4:37 PM.
Revision Contents
Revision Contents
| Path | Packages | |||
|---|---|---|---|---|
| M | contrib/python3-whitelist (1 line) | |||
| M | hgext/remotefilelog/datapack.py (2 lines) |
| Commit | Parents | Author | Summary | Date |
|---|---|---|---|---|
| Gregory Szorc | Jan 30 2019, 4:36 PM |
Diff 13597
Diff 13597
contrib/python3-whitelist
| test-remotefilelog-bad-configs.t | test-remotefilelog-bad-configs.t | ||||
| test-remotefilelog-bgprefetch.t | test-remotefilelog-bgprefetch.t | ||||
| test-remotefilelog-blame.t | test-remotefilelog-blame.t | ||||
| test-remotefilelog-bundle2.t | test-remotefilelog-bundle2.t | ||||
| test-remotefilelog-bundles.t | test-remotefilelog-bundles.t | ||||
| test-remotefilelog-cacheprocess.t | test-remotefilelog-cacheprocess.t | ||||
| test-remotefilelog-clone-tree.t | test-remotefilelog-clone-tree.t | ||||
| test-remotefilelog-clone.t | test-remotefilelog-clone.t | ||||
| test-remotefilelog-datapack.py | |||||
| test-remotefilelog-gcrepack.t | test-remotefilelog-gcrepack.t | ||||
| test-remotefilelog-histpack.py | test-remotefilelog-histpack.py | ||||
| test-remotefilelog-http.t | test-remotefilelog-http.t | ||||
| test-remotefilelog-keepset.t | test-remotefilelog-keepset.t | ||||
| test-remotefilelog-local.t | test-remotefilelog-local.t | ||||
| test-remotefilelog-log.t | test-remotefilelog-log.t | ||||
| test-remotefilelog-partial-shallow.t | test-remotefilelog-partial-shallow.t | ||||
| test-remotefilelog-permissions.t | test-remotefilelog-permissions.t | ||||
hgext/remotefilelog/datapack.py
| entrylen = self.INDEXENTRYLENGTH | entrylen = self.INDEXENTRYLENGTH | ||||
| if startnode == node: | if startnode == node: | ||||
| entry = index[start:start + entrylen] | entry = index[start:start + entrylen] | ||||
| elif endnode == node: | elif endnode == node: | ||||
| entry = index[end:end + entrylen] | entry = index[end:end + entrylen] | ||||
| else: | else: | ||||
| while start < end - entrylen: | while start < end - entrylen: | ||||
| mid = start + (end - start) / 2 | mid = start + (end - start) / 2 | ||||
| mid = mid - ((mid - params.indexstart) % entrylen) | mid = int(mid - ((mid - params.indexstart) % entrylen)) | ||||
| midnode = index[mid:mid + NODELENGTH] | midnode = index[mid:mid + NODELENGTH] | ||||
| if midnode == node: | if midnode == node: | ||||
| entry = index[mid:mid + entrylen] | entry = index[mid:mid + entrylen] | ||||
| break | break | ||||
| if node > midnode: | if node > midnode: | ||||
| start = mid | start = mid | ||||
| elif node < midnode: | elif node < midnode: | ||||
| end = mid | end = mid | ||||