This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	indygreg	D5846 tests: add syntax warnings on Python 3.8 in python-zstandard
Closed	indygreg	D5845 check-py3-compat: manually format and print warnings
Closed	indygreg	D5844 check-py3-compat: provide filename to ast.parse()
Closed	indygreg	D5843 doc: escape backslash
Closed	indygreg	D5842 testparseutil: escape backslash in docstring
Closed	indygreg	D5841 tests: use raw strings in test-help.t
Closed	indygreg	D5840 tests: escape backslash in makepatch.py inline file
Closed	indygreg	D5839 tests: use raw strings in test-cbor.py
Closed	indygreg	D5838 showstack: use raw docstring
Closed	indygreg	D5837 tests: use raw string in test-check-code.t
Closed	indygreg	D5831 run-tests: set attributes in sorted order
Closed	indygreg	D5830 revetbenchmarks: use raw string for regular expression with escapes
Closed	indygreg	D5829 check-code: use raw string
Closed	indygreg	D5828 tests: use raw strings for regular expressions with escapes
Closed	indygreg	D5827 drawdag: use raw strings for docstrings
Closed	indygreg	D5826 check-config: use raw strings for regular expressions
Closed	indygreg	D5825 run-tests: use raw strings for regular expressions
Closed	indygreg	D5824 check-commit: use raw string for regular expression

Diff 13751

	# Forbid "_" in function name.			# Forbid "_" in function name.
	#			#
	# We skip the check for cffi related functions. They use names mapping the			# We skip the check for cffi related functions. They use names mapping the
	# name of the C function. C function names may contain "_".			# name of the C function. C function names may contain "_".
	(r"\n\+[ \t]+def (?!cffi)[a-z]+_[a-z]",			(r"\n\+[ \t]+def (?!cffi)[a-z]+_[a-z]",
	"adds a function with foo_bar naming"),			"adds a function with foo_bar naming"),
	]			]

	word = re.compile('\S')			word = re.compile(r'\S')
	def nonempty(first, second):			def nonempty(first, second):
	if word.search(first):			if word.search(first):
	return first			return first
	return second			return second

	def checkcommit(commit, node=None):			def checkcommit(commit, node=None):
	exitcode = 0			exitcode = 0
	printed = node is None			printed = node is None