( )⚙ D5842 testparseutil: escape backslash in docstring

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5842

testparseutil: escape backslash in docstring
ClosedPublic

Authored by indygreg on Feb 4 2019, 5:47 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG99b4c6d73a72: testparseutil: escape backslash in docstring
Summary

This is funky. This inline Python code is part of a docstring, which
means the string is interpreted first. So any backslashes need double
escaping. So even though this is already a br'', we still need to escape.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Feb 4 2019, 5:47 PM
Closed by commit rHG99b4c6d73a72: testparseutil: escape backslash in docstring (authored by indygreg). · Explain WhyFeb 4 2019, 6:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/testparseutil.py (2 lines)

Diff 13769

contrib/testparseutil.py

# - << LIMITMARK # - << LIMITMARK
# - << "LIMITMARK" # - << "LIMITMARK"
# - << 'LIMITMARK' # - << 'LIMITMARK'
heredoclimitpat = br'\s*<<\s*(?P<lquote>["\']?)(?P<limit>\w+)(?P=lquote)' heredoclimitpat = br'\s*<<\s*(?P<lquote>["\']?)(?P<limit>\w+)(?P=lquote)'
class fileheredocmatcher(embeddedmatcher): class fileheredocmatcher(embeddedmatcher):
"""Detect "cat > FILE << LIMIT" style embedded code """Detect "cat > FILE << LIMIT" style embedded code
>>> matcher = fileheredocmatcher(b'heredoc .py file', br'[^<]+\.py') >>> matcher = fileheredocmatcher(b'heredoc .py file', br'[^<]+\\.py')
>>> b2s(matcher.startsat(b' $ cat > file.py << EOF\\n')) >>> b2s(matcher.startsat(b' $ cat > file.py << EOF\\n'))
('file.py', ' > EOF\\n') ('file.py', ' > EOF\\n')
>>> b2s(matcher.startsat(b' $ cat >>file.py <<EOF\\n')) >>> b2s(matcher.startsat(b' $ cat >>file.py <<EOF\\n'))
('file.py', ' > EOF\\n') ('file.py', ' > EOF\\n')
>>> b2s(matcher.startsat(b' $ cat> \\x27any file.py\\x27<< "EOF"\\n')) >>> b2s(matcher.startsat(b' $ cat> \\x27any file.py\\x27<< "EOF"\\n'))
('any file.py', ' > EOF\\n') ('any file.py', ' > EOF\\n')
>>> b2s(matcher.startsat(b" $ cat > file.py << 'ANYLIMIT'\\n")) >>> b2s(matcher.startsat(b" $ cat > file.py << 'ANYLIMIT'\\n"))
('file.py', ' > ANYLIMIT\\n') ('file.py', ' > ANYLIMIT\\n')