This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5845

check-py3-compat: manually format and print warnings
ClosedPublic

Authored by indygreg on Feb 4 2019, 5:47 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGba7eaff26474: check-py3-compat: manually format and print warnings
Summary

The warnings mechanism may print to stderr on Python 3. Independent buffering
of stdout and stderr can lead to warnings output not being printed properly.

This commit traps warnings when executing individual files and prints
warnings to stdout so output is deterministic.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 4 2019, 5:47 PM
Closed by commit rHGba7eaff26474: check-py3-compat: manually format and print warnings (authored by indygreg). · Explain WhyFeb 4 2019, 6:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/check-py3-compat.py (8 lines)

Diff 13799

contrib/check-py3-compat.py

#!/usr/bin/env python #!/usr/bin/env python
# #
# check-py3-compat - check Python 3 compatibility of Mercurial files # check-py3-compat - check Python 3 compatibility of Mercurial files
# #
# Copyright 2015 Gregory Szorc <gregory.szorc@gmail.com> # Copyright 2015 Gregory Szorc <gregory.szorc@gmail.com>
# #
# This software may be used and distributed according to the terms of the # This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version. # GNU General Public License version 2 or any later version.
from __future__ import absolute_import, print_function from __future__ import absolute_import, print_function
import ast import ast
import importlib import importlib
import os import os
import sys import sys
import traceback import traceback
import warnings
def check_compat_py2(f): def check_compat_py2(f):
"""Check Python 3 compatibility for a file with Python 2""" """Check Python 3 compatibility for a file with Python 2"""
with open(f, 'rb') as fh: with open(f, 'rb') as fh:
content = fh.read() content = fh.read()
root = ast.parse(content) root = ast.parse(content)
# Ignore empty files. # Ignore empty files.
if __name__ == '__main__': if __name__ == '__main__':
if sys.version_info[0] == 2: if sys.version_info[0] == 2:
fn = check_compat_py2 fn = check_compat_py2
else: else:
fn = check_compat_py3 fn = check_compat_py3
for f in sys.argv[1:]: for f in sys.argv[1:]:
with warnings.catch_warnings(record=True) as warns:
fn(f) fn(f)
for w in warns:
print(warnings.formatwarning(w.message, w.category,
w.filename, w.lineno).rstrip())
sys.exit(0) sys.exit(0)