Page MenuHomePhabricator

merge: don't unnecessarily calculate absolute path
ClosedPublic

Authored by martinvonz on Feb 5 2019, 12:26 PM.

Details

Summary

I think this also makes the code clearer (and prepares for a later
patch that replaces origpath()).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Feb 5 2019, 12:26 PM
pulkit accepted this revision.Feb 5 2019, 12:39 PM
pulkit added a subscriber: pulkit.

I think this also makes the code clearer (and prepares for the next
patch).

I don't see a next patch.

In D5849#85665, @pulkit wrote:

I think this also makes the code clearer (and prepares for the next
patch).

I don't see a next patch.

Oops, true. I'll rephase to be more vague :)

martinvonz edited the summary of this revision. (Show Details)Feb 5 2019, 12:41 PM
This revision was automatically updated to reflect the committed changes.