This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5880

fsmonitor: rename new verbose config knob
ClosedPublic

Authored by lothiraldan on Feb 7 2019, 11:06 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG286eeed14893: fsmonitor: rename new verbose config knob
Summary

The config knob was introduced in this release cycle under the old extension
name, rename it before it is part of a release.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lothiraldan created this revision.Feb 7 2019, 11:06 AM
pulkit added a subscriber: pulkit.Feb 7 2019, 11:12 AM

Looks like you missed updating the users of this config.

lothiraldan added a comment.Feb 7 2019, 12:09 PM

Nice catch, sorry for the hasty phabsend

pulkit accepted this revision.Feb 7 2019, 12:57 PM
pulkit added inline comments.
hgext/fsmonitor/__init__.py
177–178

will change this one also in flight.

pulkit added a comment.Feb 7 2019, 1:06 PM

I am unable to find any docs for this config option, can you add them as a follow-up?

Closed by commit rHG286eeed14893: fsmonitor: rename new verbose config knob (authored by lothiraldan). · Explain WhyFeb 7 2019, 1:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/fsmonitor/__init__.py (10 lines)

Diff 13891

hgext/fsmonitor/__init__.py

default=False, default=False,
) )
configitem('fsmonitor', 'timeout', configitem('fsmonitor', 'timeout',
default='2', default='2',
) )
configitem('fsmonitor', 'blacklistusers', configitem('fsmonitor', 'blacklistusers',
default=list, default=list,
) )
configitem('hgwatchman', 'verbose', configitem('fsmonitor', 'verbose',
default=True, default=True,
) )
configitem('experimental', 'fsmonitor.transaction_notify', configitem('experimental', 'fsmonitor.transaction_notify',
default=False, default=False,
) )
# This extension is incompatible with the following blacklisted extensions # This extension is incompatible with the following blacklisted extensions
# and will disable itself when encountering one of these: # and will disable itself when encountering one of these:
_blacklist = ['largefiles', 'eol'] _blacklist = ['largefiles', 'eol']
def _handleunavailable(ui, state, ex): def _handleunavailable(ui, state, ex):
"""Exception handler for Watchman interaction exceptions""" """Exception handler for Watchman interaction exceptions"""
if isinstance(ex, watchmanclient.Unavailable): if isinstance(ex, watchmanclient.Unavailable):
# experimental config: hgwatchman.verbose # experimental config: fsmonitor.verbose
pulkitUnsubmitted
Not Done

will change this one also in flight.

pulkit: will change this one also in flight.
if ex.warn and ui.configbool('hgwatchman', 'verbose'): if ex.warn and ui.configbool('fsmonitor', 'verbose'):
ui.warn(str(ex) + '\n') ui.warn(str(ex) + '\n')
if ex.invalidate: if ex.invalidate:
state.invalidate() state.invalidate()
# experimental config: hgwatchman.verbose # experimental config: fsmonitor.verbose
if ui.configbool('hgwatchman','verbose'): if ui.configbool('fsmonitor', 'verbose'):
ui.log('fsmonitor', 'Watchman unavailable: %s\n', ex.msg) ui.log('fsmonitor', 'Watchman unavailable: %s\n', ex.msg)
else: else:
ui.log('fsmonitor', 'Watchman exception: %s\n', ex) ui.log('fsmonitor', 'Watchman exception: %s\n', ex)
def _hashignore(ignore): def _hashignore(ignore):
"""Calculate hash for ignore patterns and filenames """Calculate hash for ignore patterns and filenames
If this information changes between Mercurial invocations, we can't If this information changes between Mercurial invocations, we can't