This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5920

remotefilelog: replace matchandpats() by match()
ClosedPublic

Authored by martinvonz on Feb 9 2019, 3:25 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG62bf34f70fe8: remotefilelog: replace matchandpats() by match()
Summary

It doesn't seem like replacing "pats" was useful here. Replacing ("",)
by [] doesn't seem like it would make a difference and glob-expansion
only happens on Windows. It seem like we should just pass the patterns
on to orig() unmodified.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Feb 9 2019, 3:25 AM
pulkit accepted this revision.Feb 9 2019, 4:39 PM
Closed by commit rHG62bf34f70fe8: remotefilelog: replace matchandpats() by match() (authored by martinvonz). · Explain WhyFeb 9 2019, 5:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/remotefilelog/__init__.py (3 lines)

Diff 13947

hgext/remotefilelog/__init__.py

# non-working-copy-parent revs. # non-working-copy-parent revs.
if not follow or revs: if not follow or revs:
# This forces the slowpath # This forces the slowpath
opts[r'removed'] = True opts[r'removed'] = True
# If this is a non-follow log without any revs specified, recommend that # If this is a non-follow log without any revs specified, recommend that
# the user add -f to speed it up. # the user add -f to speed it up.
if not follow and not revs: if not follow and not revs:
match, pats = scmutil.matchandpats(repo['.'], pats, match = scmutil.match(repo['.'], pats, pycompat.byteskwargs(opts))
pycompat.byteskwargs(opts))
isfile = not match.anypats() isfile = not match.anypats()
if isfile: if isfile:
for file in match.files(): for file in match.files():
if not os.path.isfile(repo.wjoin(file)): if not os.path.isfile(repo.wjoin(file)):
isfile = False isfile = False
break break
if isfile: if isfile: