( )⚙ D5921 scmutil: remove special handling of pats==("",) in matchandpats() (API)

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5921

scmutil: remove special handling of pats==("",) in matchandpats() (API)
ClosedPublic

Authored by martinvonz on Feb 10 2019, 1:19 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGa950b65cbe1b: scmutil: remove special handling of pats==("",) in matchandpats() (API)
Summary

I don't know under what circumstances we used to pass that value, but
we don't seem to do it now.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mmercurial/scmutil.py (2 lines)

Diff 14002

mercurial/scmutil.py

ret.append(kindpat) ret.append(kindpat)
return ret return ret
def matchandpats(ctx, pats=(), opts=None, globbed=False, default='relpath', def matchandpats(ctx, pats=(), opts=None, globbed=False, default='relpath',
badfn=None): badfn=None):
'''Return a matcher and the patterns that were used. '''Return a matcher and the patterns that were used.
The matcher will warn about bad matches, unless an alternate badfn callback The matcher will warn about bad matches, unless an alternate badfn callback
is provided.''' is provided.'''
if pats == ("",):
pats = []
if opts is None: if opts is None:
opts = {} opts = {}
if not globbed and default == 'relpath': if not globbed and default == 'relpath':
pats = expandpats(pats or []) pats = expandpats(pats or [])
uipathfn = getuipathfn(ctx.repo(), legacyrelativevalue=True) uipathfn = getuipathfn(ctx.repo(), legacyrelativevalue=True)
def bad(f, msg): def bad(f, msg):
ctx.repo().ui.warn("%s: %s\n" % (uipathfn(f), msg)) ctx.repo().ui.warn("%s: %s\n" % (uipathfn(f), msg))