diff: make sure we output stat info even when --git is not passed (issue4037)
ClosedPublic

Authored by pulkit on Fri, Feb 22, 6:29 PM.

Details

Summary

Before this patch, hg diff --stat will give an empty output. It will not show
the stat information. I debugged and found that the underlying code does not
return the diff header and due to that, other code paths fails to parse that as
a diff.

I looked into why we don't return diff headers in quiet mode and found the
behavior is from 8f8bb77d560e70bcc95577e4dfa877df18d876ab which does not have
any mention about why it is done. We also show the diff headers in git, so I
think it's fine showing diff header in normal diff in quiet mode.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pulkit created this revision.Fri, Feb 22, 6:29 PM
yuja added a subscriber: yuja.Sun, Feb 24, 8:36 PM
I looked into why we don't return diff headers in quiet mode and found the
behavior is from https://phab.mercurial-scm.org/rHG8f8bb77d560e70bcc95577e4dfa877df18d876ab which does not have
any mention about why it is done. We also show the diff headers in git, so I
think it's fine showing diff header in normal diff in quiet mode.

Agreed. Flagged as BC and queued, thanks.

This revision was automatically updated to reflect the committed changes.