( )⚙ D6033 py3: convert return values of inspect.getabsfile() to bytes

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6033

py3: convert return values of inspect.getabsfile() to bytes
ClosedPublic

Authored by pulkit on Feb 27 2019, 5:46 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG78027e7bc544: py3: convert return values of inspect.getabsfile() to bytes
Summary

It's weird that python docs for inspect does not mention getabsfile().

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Feb 27 2019, 5:46 PM
Closed by commit rHG78027e7bc544: py3: convert return values of inspect.getabsfile() to bytes (authored by pulkit). · Explain WhyFeb 27 2019, 8:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/chgserver.py (2 lines)

Diff 14260

mercurial/chgserver.py

try: try:
from . import __version__ from . import __version__
modules.append(__version__) modules.append(__version__)
except ImportError: except ImportError:
pass pass
files = [pycompat.sysexecutable] files = [pycompat.sysexecutable]
for m in modules: for m in modules:
try: try:
files.append(inspect.getabsfile(m)) files.append(pycompat.fsencode(inspect.getabsfile(m)))
except TypeError: except TypeError:
pass pass
return sorted(set(files)) return sorted(set(files))
def _mtimehash(paths): def _mtimehash(paths):
"""return a quick hash for detecting file changes """return a quick hash for detecting file changes
mtimehash calls stat on given paths and calculate a hash based on size and mtimehash calls stat on given paths and calculate a hash based on size and