This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6065

setup: exclude some internal UCRT files
ClosedPublic

Authored by indygreg on Mar 3 2019, 6:51 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGdb3098d02a6d: setup: exclude some internal UCRT files
Summary

When attempting to build the Inno installer locally, I was getting
several file not found errors when py2exe was crawling DLL
dependencies. The missing DLLs appear to be "internal" DLLs
used by the Universal C Runtime (UCRT). In many cases, the
missing DLLs don't appear to exist on my system at all!
Some of the DLLs have version numbers that appear to be N+1
of what the existing version number is. Maybe the "public" UCRT
DLLs are probing for version N+1 at load time and py2exe is
picking these up? Who knows.

This commit adds the non-public UCRT DLLs as found by
py2exe on my system to the excluded DLLs set. After this
change, I'm able to produce an Inno installer with an
appropriate set of DLLs.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 3 2019, 6:51 PM
Closed by commit rHGdb3098d02a6d: setup: exclude some internal UCRT files (authored by indygreg). · Explain WhyMar 5 2019, 10:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msetup.py (8 lines)

Diff 14367

setup.py

ext_modules=extmodules, ext_modules=extmodules,
data_files=datafiles, data_files=datafiles,
package_data=packagedata, package_data=packagedata,
cmdclass=cmdclass, cmdclass=cmdclass,
distclass=hgdist, distclass=hgdist,
options={ options={
'py2exe': { 'py2exe': {
'packages': py2exepackages, 'packages': py2exepackages,
'dll_excludes': [
'api-ms-win-core-apiquery-l1-1-0.dll',
'api-ms-win-core-delayload-l1-1-0.dll',
'api-ms-win-core-delayload-l1-1-1.dll',
'api-ms-win-core-heap-l2-1-0.dll',
'api-ms-win-core-libraryloader-l1-2-0.dll',
'api-ms-win-core-registry-l1-1-0.dll',
]
}, },
'bdist_mpkg': { 'bdist_mpkg': {
'zipdist': False, 'zipdist': False,
'license': 'COPYING', 'license': 'COPYING',
'readme': 'contrib/packaging/macosx/Readme.html', 'readme': 'contrib/packaging/macosx/Readme.html',
'welcome': 'contrib/packaging/macosx/Welcome.html', 'welcome': 'contrib/packaging/macosx/Welcome.html',
}, },
}, },
**extra) **extra)