Page MenuHomePhabricator

inno: stop shipping pywin32
ClosedPublic

Authored by indygreg on Mar 3 2019, 6:52 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG7a1433e90482: inno: stop shipping pywin32
Summary

Ancient versions of Mercurial relied on pywin32 and I suspect
that's why we have this dependency.

We also ship the "keyring" package, which has a dependency
on "pywin32-ctypes" (providing the "win32ctypes" package).
This is a stripped down version of pywin32 that doesn't have
as many dependencies.

Since we don't have a dependency on pywin32 and since pywin32
is a bit annoying to package, let's get rid of it.

With this change, py2exe no longers picks up DLL dependencies
on various UCRT DLLs (because we no longer have a .pyd file
beloning to pywin32 which was pulling them in). So, we were
able to remove code in support of the UCRT DLLs.

.. bc::

The Windows Inno installers no longer ship the pywin32 package.

This package was being bundled for historical reasons. Mercurial
stopped using pywin32 several years ago and the disappearance
of this package should not have any meaningful impact.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 3 2019, 6:52 PM
indygreg updated this revision to Diff 14333.Mar 3 2019, 6:53 PM
indygreg edited the summary of this revision. (Show Details)Mar 3 2019, 9:22 PM
indygreg updated this revision to Diff 14339.
This revision was automatically updated to reflect the committed changes.