( )⚙ D6070 py3: use bytes instead of str in isinstance()

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6070

py3: use bytes instead of str in isinstance()
ClosedPublic

Authored by pulkit on Mar 4 2019, 5:03 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGb1d07f4614a6: py3: use bytes instead of str in isinstance()
Summary

We use bytes everywhere.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Mar 4 2019, 5:03 PM
Kwan added a subscriber: Kwan.Mar 4 2019, 5:53 PM
Closed by commit rHGb1d07f4614a6: py3: use bytes instead of str in isinstance() (authored by pulkit). · Explain WhyMar 4 2019, 6:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/tags.py (2 lines)

Diff 14354

mercurial/tags.py

with repo.wlock(): with repo.wlock():
repo.tags() # instantiate the cache repo.tags() # instantiate the cache
_tag(repo, names, node, message, local, user, date, _tag(repo, names, node, message, local, user, date,
editor=editor) editor=editor)
def _tag(repo, names, node, message, local, user, date, extra=None, def _tag(repo, names, node, message, local, user, date, extra=None,
editor=False): editor=False):
if isinstance(names, str): if isinstance(names, bytes):
names = (names,) names = (names,)
branches = repo.branchmap() branches = repo.branchmap()
for name in names: for name in names:
repo.hook('pretag', throw=True, node=hex(node), tag=name, repo.hook('pretag', throw=True, node=hex(node), tag=name,
local=local) local=local)
if name in branches: if name in branches:
repo.ui.warn(_("warning: tag %s conflicts with existing" repo.ui.warn(_("warning: tag %s conflicts with existing"