tests: simplify test-uncommit.t by removing an unnecessary commit
AbandonedPublic

Authored by martinvonz on Mar 6 2019, 6:49 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

I don't see what value the first commit adds in the test for issue
5977, so let's remove it.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped
martinvonz created this revision.Mar 6 2019, 6:49 PM
pulkit added a subscriber: pulkit.Mar 7 2019, 7:30 AM
pulkit added inline comments.
tests/test-uncommit.t
483

I skimmed through the whole file and could not find a case where we do hg uncommit PATH on a dirty wdir and PATH is not dirty in wdir. So I think it's better to have this test.

martinvonz added inline comments.Mar 7 2019, 11:41 AM
tests/test-uncommit.t
483

Ohh, I didn't even realize that was allowed! :) And I obviously agree with testing that in that case. Could we have a separate test description for that then (so it's not just part of "--allow-dirty-working-copy should also work on a dirty PATH")?

martinvonz abandoned this revision.Mar 8 2019, 12:09 PM