( )⚙ D6085 packaging: move DOWNLOADS dict to hgpackaging.downloads

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6085

packaging: move DOWNLOADS dict to hgpackaging.downloads
ClosedPublic

Authored by indygreg on Mar 7 2019, 7:49 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG1e8fb6522fee: packaging: move DOWNLOADS dict to hgpackaging.downloads
Summary

We'll want to keep state in sync between multiple packaging tools.
It makes sense to share a central data structure defining downloads.

We also change the function to return the downloads entry so
callers don't have to access the global DOWNLOADS in the new
location.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 7 2019, 7:49 PM
Closed by commit rHG1e8fb6522fee: packaging: move DOWNLOADS dict to hgpackaging.downloads (authored by indygreg). · Explain WhyMar 9 2019, 8:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 14440

contrib/packaging/hgpackaging/downloads.py

# downloads.py - Code for downloading dependencies. # downloads.py - Code for downloading dependencies.
# #
# Copyright 2019 Gregory Szorc <gregory.szorc@gmail.com> # Copyright 2019 Gregory Szorc <gregory.szorc@gmail.com>
# #
# This software may be used and distributed according to the terms of the # This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version. # GNU General Public License version 2 or any later version.
# no-check-code because Python 3 native. # no-check-code because Python 3 native.
import gzip import gzip
import hashlib import hashlib
import pathlib import pathlib
import urllib.request import urllib.request
DOWNLOADS = {
'gettext': {
'url': 'https://versaweb.dl.sourceforge.net/project/gnuwin32/gettext/0.14.4/gettext-0.14.4-bin.zip',
'size': 1606131,
'sha256': '60b9ef26bc5cceef036f0424e542106cf158352b2677f43a01affd6d82a1d641',
'version': '0.14.4',
},
'gettext-dep': {
'url': 'https://versaweb.dl.sourceforge.net/project/gnuwin32/gettext/0.14.4/gettext-0.14.4-dep.zip',
'size': 715086,
'sha256': '411f94974492fd2ecf52590cb05b1023530aec67e64154a88b1e4ebcd9c28588',
},
'py2exe': {
'url': 'https://versaweb.dl.sourceforge.net/project/py2exe/py2exe/0.6.9/py2exe-0.6.9.zip',
'size': 149687,
'sha256': '6bd383312e7d33eef2e43a5f236f9445e4f3e0f6b16333c6f183ed445c44ddbd',
'version': '0.6.9',
},
'virtualenv': {
'url': 'https://files.pythonhosted.org/packages/37/db/89d6b043b22052109da35416abc3c397655e4bd3cff031446ba02b9654fa/virtualenv-16.4.3.tar.gz',
'size': 3713208,
'sha256': '984d7e607b0a5d1329425dd8845bd971b957424b5ba664729fab51ab8c11bc39',
'version': '16.4.3',
},
}
def hash_path(p: pathlib.Path): def hash_path(p: pathlib.Path):
h = hashlib.sha256() h = hashlib.sha256()
with p.open('rb') as fh: with p.open('rb') as fh:
while True: while True:
chunk = fh.read(65536) chunk = fh.read(65536)
if not chunk: if not chunk:
break break
except IntegrityError: except IntegrityError:
tmp.unlink() tmp.unlink()
raise raise
tmp.rename(path) tmp.rename(path)
print('successfully downloaded %s' % url) print('successfully downloaded %s' % url)
def download_entry(entry: dict, dest_path: pathlib.Path, local_name=None) -> pathlib.Path: def download_entry(name: dict, dest_path: pathlib.Path, local_name=None) -> pathlib.Path:
entry = DOWNLOADS[name]
url = entry['url'] url = entry['url']
local_name = local_name or url[url.rindex('/') + 1:] local_name = local_name or url[url.rindex('/') + 1:]
local_path = dest_path / local_name local_path = dest_path / local_name
download_to_path(url, local_path, entry['size'], entry['sha256']) download_to_path(url, local_path, entry['size'], entry['sha256'])
return local_path return local_path, entry

contrib/packaging/inno/build.py

import os import os
import pathlib import pathlib
import shutil import shutil
import subprocess import subprocess
import sys import sys
import tempfile import tempfile
DOWNLOADS = {
'gettext': {
'url': 'https://versaweb.dl.sourceforge.net/project/gnuwin32/gettext/0.14.4/gettext-0.14.4-bin.zip',
'size': 1606131,
'sha256': '60b9ef26bc5cceef036f0424e542106cf158352b2677f43a01affd6d82a1d641',
'version': '0.14.4',
},
'gettext-dep': {
'url': 'https://versaweb.dl.sourceforge.net/project/gnuwin32/gettext/0.14.4/gettext-0.14.4-dep.zip',
'size': 715086,
'sha256': '411f94974492fd2ecf52590cb05b1023530aec67e64154a88b1e4ebcd9c28588',
},
'py2exe': {
'url': 'https://versaweb.dl.sourceforge.net/project/py2exe/py2exe/0.6.9/py2exe-0.6.9.zip',
'size': 149687,
'sha256': '6bd383312e7d33eef2e43a5f236f9445e4f3e0f6b16333c6f183ed445c44ddbd',
'version': '0.6.9',
},
'virtualenv': {
'url': 'https://files.pythonhosted.org/packages/37/db/89d6b043b22052109da35416abc3c397655e4bd3cff031446ba02b9654fa/virtualenv-16.4.3.tar.gz',
'size': 3713208,
'sha256': '984d7e607b0a5d1329425dd8845bd971b957424b5ba664729fab51ab8c11bc39',
'version': '16.4.3',
},
}
PRINT_PYTHON_INFO = ''' PRINT_PYTHON_INFO = '''
import platform, sys; print("%s:%d" % (platform.architecture()[0], sys.version_info[0])) import platform, sys; print("%s:%d" % (platform.architecture()[0], sys.version_info[0]))
'''.strip() '''.strip()
def find_vc_runtime_files(x64=False): def find_vc_runtime_files(x64=False):
"""Finds Visual C++ Runtime DLLs to include in distribution.""" """Finds Visual C++ Runtime DLLs to include in distribution."""
winsxs = pathlib.Path(os.environ['SYSTEMROOT']) / 'WinSxS' winsxs = pathlib.Path(os.environ['SYSTEMROOT']) / 'WinSxS'
raise Exception('architecture mismatch: Visual C++ environment ' raise Exception('architecture mismatch: Visual C++ environment '
'is configured for 32-bit but Python is 64-bit') 'is configured for 32-bit but Python is 64-bit')
if py_version != 2: if py_version != 2:
raise Exception('Only Python 2 is currently supported') raise Exception('Only Python 2 is currently supported')
build_dir.mkdir(exist_ok=True) build_dir.mkdir(exist_ok=True)
gettext_pkg = download_entry(DOWNLOADS['gettext'], build_dir) gettext_pkg, gettext_entry = download_entry('gettext', build_dir)
gettext_dep_pkg = download_entry(DOWNLOADS['gettext-dep'], build_dir) gettext_dep_pkg = download_entry('gettext-dep', build_dir)[0]
virtualenv_pkg = download_entry(DOWNLOADS['virtualenv'], build_dir) virtualenv_pkg, virtualenv_entry = download_entry('virtualenv', build_dir)
py2exe_pkg = download_entry(DOWNLOADS['py2exe'], build_dir) py2exe_pkg, py2exe_entry = download_entry('py2exe', build_dir)
venv_path = build_dir / ('venv-inno-%s' % ('x64' if vc_x64 else 'x86')) venv_path = build_dir / ('venv-inno-%s' % ('x64' if vc_x64 else 'x86'))
gettext_root = build_dir / ( gettext_root = build_dir / (
'gettext-win-%s' % DOWNLOADS['gettext']['version']) 'gettext-win-%s' % gettext_entry['version'])
if not gettext_root.exists(): if not gettext_root.exists():
extract_zip_to_directory(gettext_pkg, gettext_root) extract_zip_to_directory(gettext_pkg, gettext_root)
extract_zip_to_directory(gettext_dep_pkg, gettext_root) extract_zip_to_directory(gettext_dep_pkg, gettext_root)
with tempfile.TemporaryDirectory() as td: with tempfile.TemporaryDirectory() as td:
td = pathlib.Path(td) td = pathlib.Path(td)
# This assumes Python 2. # This assumes Python 2.
extract_tar_to_directory(virtualenv_pkg, td) extract_tar_to_directory(virtualenv_pkg, td)
extract_zip_to_directory(py2exe_pkg, td) extract_zip_to_directory(py2exe_pkg, td)
virtualenv_src_path = td / ('virtualenv-%s' % virtualenv_src_path = td / ('virtualenv-%s' %
DOWNLOADS['virtualenv']['version']) virtualenv_entry['version'])
py2exe_source_path = td / ('py2exe-%s' % py2exe_source_path = td / ('py2exe-%s' %
DOWNLOADS['py2exe']['version']) py2exe_entry['version'])
virtualenv_py = virtualenv_src_path / 'virtualenv.py' virtualenv_py = virtualenv_src_path / 'virtualenv.py'
if not venv_path.exists(): if not venv_path.exists():
print('creating virtualenv with dependencies') print('creating virtualenv with dependencies')
subprocess.run( subprocess.run(
[str(python_exe), str(virtualenv_py), str(venv_path)], [str(python_exe), str(virtualenv_py), str(venv_path)],
check=True) check=True)