This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	Kwan	D6114 py3: add test-phabricator.py to python3-whitelist
Closed	Kwan	D6113 py3: convert to/from bytes/unicode for json.(dump\|load)s in debugcallconduit
Closed	Kwan	D6112 py3: use % instead of .format() on a bytestring
Closed	Kwan	D6111 py3: use r'' for group name arguments to MatchObjects in phabricator.py
Closed	Kwan	D6110 py3: use %d instead of %s when formatting an int into a byte string
Closed	Kwan	D6109 py3: only pass unicode to json.dumps in writediffproperties
Closed	Kwan	D6108 py3: fix a few "dict keys as str instead of bytes" issues in phabricator.py
Closed	Kwan	D6107 py3: use pycompat.byteskwargs on opts in phabricator.py
Closed	Kwan	D6106 py3: convert URL to str before passing it to request
Closed	Kwan	D6105 py3: convert indexes into bytes when enumerating lists in urlencodenested
Closed	Kwan	D6104 py3: don't try and format a bare dict into a byte string in callconduit
Closed	Kwan	D6103 py3: use pycompat.iterbytestr to convert memoryview slice to bytestring before passing to itertools.takewhile
Closed	Kwan	D6102 py3: use fsencode for the vcr recording paths and strings for the custom_patches arguments
Closed	Kwan	D6044 phabricator: convert conduit response JSON unicode to bytes inside callconduit

Diff 14418

	For example, if params is {'a': ['b', 'c'], 'd': {'e': 'f'}}, it will be			For example, if params is {'a': ['b', 'c'], 'd': {'e': 'f'}}, it will be
	flattened to {'a[0]': 'b', 'a[1]': 'c', 'd[e]': 'f'} and then passed to			flattened to {'a[0]': 'b', 'a[1]': 'c', 'd[e]': 'f'} and then passed to
	urlencode. Note: the encoding is consistent with PHP's http_build_query.			urlencode. Note: the encoding is consistent with PHP's http_build_query.
	"""			"""
	flatparams = util.sortdict()			flatparams = util.sortdict()
	def process(prefix, obj):			def process(prefix, obj):
	if isinstance(obj, bool):			if isinstance(obj, bool):
	obj = {True: b'true', False: b'false'}[obj] # Python -> PHP form			obj = {True: b'true', False: b'false'}[obj] # Python -> PHP form
	items = {list: enumerate, dict: lambda x: x.items()}.get(type(obj))			lister = lambda l: [(b'%d' % k, v) for k, v in enumerate(l)]
				items = {list: lister, dict: lambda x: x.items()}.get(type(obj))
	if items is None:			if items is None:
	flatparams[prefix] = obj			flatparams[prefix] = obj
	else:			else:
	for k, v in items(obj):			for k, v in items(obj):
	if prefix:			if prefix:
	process(b'%s[%s]' % (prefix, k), v)			process(b'%s[%s]' % (prefix, k), v)
	else:			else:
	process(k, v)			process(k, v)