This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	Kwan	D6114 py3: add test-phabricator.py to python3-whitelist
Closed	Kwan	D6113 py3: convert to/from bytes/unicode for json.(dump\|load)s in debugcallconduit
Closed	Kwan	D6112 py3: use % instead of .format() on a bytestring
Closed	Kwan	D6111 py3: use r'' for group name arguments to MatchObjects in phabricator.py
Closed	Kwan	D6110 py3: use %d instead of %s when formatting an int into a byte string
Closed	Kwan	D6109 py3: only pass unicode to json.dumps in writediffproperties
Closed	Kwan	D6108 py3: fix a few "dict keys as str instead of bytes" issues in phabricator.py
Closed	Kwan	D6107 py3: use pycompat.byteskwargs on opts in phabricator.py
Closed	Kwan	D6106 py3: convert URL to str before passing it to request
Closed	Kwan	D6105 py3: convert indexes into bytes when enumerating lists in urlencodenested
Closed	Kwan	D6104 py3: don't try and format a bare dict into a byte string in callconduit
Closed	Kwan	D6103 py3: use pycompat.iterbytestr to convert memoryview slice to bytestring before passing to itertools.takewhile
Closed	Kwan	D6102 py3: use fsencode for the vcr recording paths and strings for the custom_patches arguments
Closed	Kwan	D6044 phabricator: convert conduit response JSON unicode to bytes inside callconduit

Diff 14419

	if curlcmd:			if curlcmd:
	sin, sout = procutil.popen2(b'%s -d @- %s'			sin, sout = procutil.popen2(b'%s -d @- %s'
	% (curlcmd, procutil.shellquote(url)))			% (curlcmd, procutil.shellquote(url)))
	sin.write(data)			sin.write(data)
	sin.close()			sin.close()
	body = sout.read()			body = sout.read()
	else:			else:
	urlopener = urlmod.opener(repo.ui, authinfo)			urlopener = urlmod.opener(repo.ui, authinfo)
	request = util.urlreq.request(url, data=data)			request = util.urlreq.request(pycompat.strurl(url), data=data)
	with contextlib.closing(urlopener.open(request)) as rsp:			with contextlib.closing(urlopener.open(request)) as rsp:
	body = rsp.read()			body = rsp.read()
	repo.ui.debug(b'Conduit Response: %s\n' % body)			repo.ui.debug(b'Conduit Response: %s\n' % body)
	parsed = pycompat.rapply(			parsed = pycompat.rapply(
	lambda x: encoding.unitolocal(x) if isinstance(x, pycompat.unicode)			lambda x: encoding.unitolocal(x) if isinstance(x, pycompat.unicode)
	else x,			else x,
	json.loads(body)			json.loads(body)
	)			)