This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	Kwan	D6114 py3: add test-phabricator.py to python3-whitelist
Closed	Kwan	D6113 py3: convert to/from bytes/unicode for json.(dump\|load)s in debugcallconduit
Closed	Kwan	D6112 py3: use % instead of .format() on a bytestring
Closed	Kwan	D6111 py3: use r'' for group name arguments to MatchObjects in phabricator.py
Closed	Kwan	D6110 py3: use %d instead of %s when formatting an int into a byte string
Closed	Kwan	D6109 py3: only pass unicode to json.dumps in writediffproperties
Closed	Kwan	D6108 py3: fix a few "dict keys as str instead of bytes" issues in phabricator.py
Closed	Kwan	D6107 py3: use pycompat.byteskwargs on opts in phabricator.py
Closed	Kwan	D6106 py3: convert URL to str before passing it to request
Closed	Kwan	D6105 py3: convert indexes into bytes when enumerating lists in urlencodenested
Closed	Kwan	D6104 py3: don't try and format a bare dict into a byte string in callconduit
Closed	Kwan	D6103 py3: use pycompat.iterbytestr to convert memoryview slice to bytestring before passing to itertools.takewhile
Closed	Kwan	D6102 py3: use fsencode for the vcr recording paths and strings for the custom_patches arguments
Closed	Kwan	D6044 phabricator: convert conduit response JSON unicode to bytes inside callconduit

Diff 14425

	""":phabreview: Object describing the review for this changeset.			""":phabreview: Object describing the review for this changeset.
	Has attributes `url` and `id`.			Has attributes `url` and `id`.
	"""			"""
	ctx = context.resource(mapping, b'ctx')			ctx = context.resource(mapping, b'ctx')
	m = _differentialrevisiondescre.search(ctx.description())			m = _differentialrevisiondescre.search(ctx.description())
	if m:			if m:
	return templateutil.hybriddict({			return templateutil.hybriddict({
	b'url': m.group(r'url'),			b'url': m.group(r'url'),
	b'id': b"D{}".format(m.group(r'id')),			b'id': b"D%s" % m.group(r'id'),
	})			})
	else:			else:
	tags = ctx.repo().nodetags(ctx.node())			tags = ctx.repo().nodetags(ctx.node())
	for t in tags:			for t in tags:
	if _differentialrevisiontagre.match(t):			if _differentialrevisiontagre.match(t):
	url = ctx.repo().ui.config(b'phabricator', b'url')			url = ctx.repo().ui.config(b'phabricator', b'url')
	if not url.endswith(b'/'):			if not url.endswith(b'/'):
	url += b'/'			url += b'/'
	url += t			url += t

	return templateutil.hybriddict({			return templateutil.hybriddict({
	b'url': url,			b'url': url,
	b'id': t,			b'id': t,
	})			})
	return None			return None