This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6143

context: use wdirhex constant instead of calculating it
ClosedPublic

Authored by martinvonz on Mar 16 2019, 1:21 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG21cc92fea2aa: context: use wdirhex constant instead of calculating it

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Mar 16 2019, 1:21 AM
pulkit accepted this revision.Mar 16 2019, 7:15 PM
Closed by commit rHG21cc92fea2aa: context: use wdirhex constant instead of calculating it (authored by martinvonz). · Explain WhyMar 16 2019, 7:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/context.py (4 lines)

Diff 14526

mercurial/context.py

from .node import ( from .node import (
addednodeid, addednodeid,
hex, hex,
modifiednodeid, modifiednodeid,
nullid, nullid,
nullrev, nullrev,
short, short,
wdirfilenodeids, wdirfilenodeids,
wdirid, wdirhex,
) )
from . import ( from . import (
dagop, dagop,
encoding, encoding,
error, error,
fileset, fileset,
match as matchmod, match as matchmod,
obsolete as obsmod, obsolete as obsmod,
for f in d: for f in d:
if d[f] != 'r': if d[f] != 'r':
yield f yield f
def __contains__(self, key): def __contains__(self, key):
return self._repo.dirstate[key] not in "?r" return self._repo.dirstate[key] not in "?r"
def hex(self): def hex(self):
return hex(wdirid) return wdirhex
@propertycache @propertycache
def _parents(self): def _parents(self):
p = self._repo.dirstate.parents() p = self._repo.dirstate.parents()
if p[1] == nullid: if p[1] == nullid:
p = p[:-1] p = p[:-1]
# use unfiltered repo to delay/avoid loading obsmarkers # use unfiltered repo to delay/avoid loading obsmarkers
unfi = self._repo.unfiltered() unfi = self._repo.unfiltered()