This is an archive of the discontinued Mercurial Phabricator instance.

branchcache: have a hasnode function to validate nodes
ClosedPublic

Authored by pulkit on Mar 19 2019, 9:40 AM.

Details

Summary

Upcoming patches will delay node validation until it's required. So we need to a
way in branchcache class to check whether a node exists or node.

Other options were making repo or changelog an attribute of branchcache object.
But the branchcache depends on filters so I decided to pass a function object.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Mar 19 2019, 9:40 AM
This revision was automatically updated to reflect the committed changes.