Page MenuHomePhabricator

discovery: stop direct use of attribute of partialdiscovery
AbandonedPublic

Authored by gracinet on Apr 12 2019, 2:33 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

Instead of accessing undecided directly for ui display purposes,
we introduce a stats() method that could be extended in the future with
more interesting information.

This is in preparation for a forthcoming Rust version of this object.
Indeed, attributes and furthermore properties are a bit complicated for
classes in native code.

We could go further and rename undecided to mark it private, but _undecided
is already taken as support for _undecided lazyness.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

gracinet created this revision.Apr 12 2019, 2:33 PM

Oops sorry, this one has already been queued by @pulkit (sent it by email, but it was still a draft in my stack).

Oops sorry, this one has already been queued by @pulkit (sent it by email, but it was still a draft in my stack).

Can be marked as Abandoned.

gracinet abandoned this revision.Apr 15 2019, 5:37 AM

@pulkit, thanks, abandoned this one.