( )⚙ D6290 branchcache: don't verify all nodes while writing

This is an archive of the discontinued Mercurial Phabricator instance.

branchcache: don't verify all nodes while writing
ClosedPublic

Authored by pulkit on Apr 19 2019, 5:00 PM.

Details

Summary

nodes are verified either when they are added or used. In case of commits. we
will load the whole branchmap, only verify nodes for the branch on which we are
committing and then we write.

However before this patch, writing the branchmap was validating all the nodes
whereas it should not. This patch fixes that.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Apr 19 2019, 5:00 PM
yuja added a subscriber: yuja.Apr 21 2019, 5:47 AM
However before this patch, writing the branchmap was validating all the nodes
whereas it should not. This patch fixes that.

Queued for stable as it smells like a regression, thanks.

This revision was automatically updated to reflect the committed changes.